dEQP-VK.graphicsfuzz.two-loops-matrix about llpc

[kuhar]

This fails in llpcCompiler.cpp:220:

class LlpcDiagnosticHandler : public llvm::DiagnosticHandler
{
    bool handleDiagnostics(const DiagnosticInfo& diagInfo) override
    {
        if (EnableOuts() || EnableErrs())
        {
            if ((diagInfo.getSeverity() == DS_Error) || (diagInfo.getSeverity() == DS_Warning))
            {
                DiagnosticPrinterRawOStream printStream(outs());
                printStream << "ERROR: LLVM DIAGNOSIS INFO: ";
                diagInfo.print(printStream);
                printStream << "\n";
                outs().flush();
            }
           ...
        }
==>     LLPC_ASSERT(diagInfo.getSeverity() != DS_Error);
        return true;
    }
};

With the error message: unsupported dynamic alloca.
Not sure what the intention was here -- perhaps to emit diagnostics and terminate on DS_Errors? In that case, I'd expect to see something like llvm::report_fatal_error used instead of the assertion.

Similar applies to issue #214.

[linqun]

please check whether there are some alloca in the middle of function. if yes, please try to find which pass add it and try to move it to the begin of function.

[MarcinKantochAMD]

Hi Paul. I tested today and can't reproduce the issue anymore.

[MarcinKantochAMD]

Sorry Paul. I was not aware that your issues relate to Debug build. I was testing with a Release build.

[kuhar]

This issue is fixed and can be closed.

[paulthomson]

Appears to be fixed!