GithubHelp home page GithubHelp logo

Comments (4)

res2k avatar res2k commented on May 30, 2024

This approach can break under several circumstances:

  • When vulkan_win32.h is changed and makes use of additional Windows types: they're not found.
  • Those typedefs are, strictly speaking, windows.h implementation details: They may change in some future SDK update.
  • There may be some other conflicts if windows.h is included before or after that bit.

While you may be able to live with the limitations, they're somewhat unsuited for a header that should work in a wide variety of projects.

from vulkanmemoryallocator.

jesta88 avatar jesta88 commented on May 30, 2024

Yes these are the risks. Other popular vulkan libraries opted to remove windows.h anyways because realistically, this should be extremely rare (if ever, in the lifetime of a major Vulkan version) and is trivial to fix.

I understand if the owners don't see it that way though.

from vulkanmemoryallocator.

res2k avatar res2k commented on May 30, 2024

If I wanted to get rid of windows.h but keep VK_USE_PLATFORM_WIN32_KHR, I might create a wrapper header that does something like you did above, with a #define VULKAN_H_ after #include <vulkan/vulkan_win32.h> and immediately including vk_mem_alloc.h. It should give the result you desire.

If you name your wrapper vk_mem_alloc.h (with the "real" header named differently, of course) you'll even get a transparent solution.

from vulkanmemoryallocator.

adam-sawicki-a avatar adam-sawicki-a commented on May 30, 2024

In my opinion @res2k is right. The solution proposed is a hack and may not be reliable or future-proof. If Vulkan header includes "windows.h" then please contact the developers of Vulkan SDK with request to change that.

Many Windows applications include and use "windows.h" anyway. To speed up compilation under Visual Studio I recommend putting it in precompiled header.

from vulkanmemoryallocator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.