Comments (2)
@simskij In the future, I recommend utilizing pull requests from another to implement changes. This way, the dev version can be updated automatically and tested prior to merging changes to main. This also gives you the opportunity to designate what type of orb update to make to the registry (if providing a production update).
I do not see your orb listed on the registry yet: https://circleci.com/orbs/registry/orb/k6io/circleci-orb
We will get this published be merging a PR to main with [semver:major]
in the title.
https://circleci.com/docs/2.0/creating-orbs/#issue-a-new-release
Review items:
- The orb imports itself:
- https://github.com/k6io/circleci-orb/blob/2c22c549363229023d06395de32e7b20480d8d58/src/%40orb.yml#L11
- The orb should not be importing itself here. This is in case your orb relies on components from other orbs. For instance, the AWS orbs often rely on the AWS CLI orb to install the AWS CLI.
- Remove the
orbs:
stanza entirely.
- Update README
- Update About Section
- Add website link to orb registry under about
The first item above appears to be the only required change. Let's issue this change and publish version 1.0.0 publically to the orb registry using the method mentioned above.
Once the change is made and the orb is published we should be good to go 👍
from k6-circleci-orb.
@KyleTryon Thanks a bunch for the review! I just pushed a new version of the orb to both GitHub and the orb registry, which I think takes care of the items on your list. Would you mind having another look?
from k6-circleci-orb.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from k6-circleci-orb.