Need a way to stop tempo from using dual stack urls for s3 backend about tempo

[Shreyank031]

Hi @mapno , Had there been any updates on the functionality implementation part. We're also facing a similar issue and It'd greatly help our use case to not use s3 on a dualstack mode. Let us know if we can help in there somehow, but would appreciate a faster expedition. Though Tempo is fairly new to me, I've been practicing Go for sometime now. Let me know if I can contribute here. If its fine, I can create a fresh PR and you can review and point me in the right direction. Thanks

[tejasraj-jar]

Facing the same issue

[Naresh-Srinivas]

Facing the same issue

[shubhamivane]

Same here :(.

[mapno]

Hi! We use minio-go as client in Tempo for S3. The ability to enable/disable dualstack endpoints was recently added and seems to already be available in the latest release.

Support for this in Tempo would require updating the client and adding a new config option for S3 backends to control it. Would you be up for this change?

[rohan-changejar]

Yes, certainly up for the change, this has significant cost impact for us. Can you please guide us through the process

[rohan-changejar]

adding here for information

[mapno]

You'll need to update the library minio/minio-go to the v7.0.70 release (you can run make vendor-check to validate that the library is correctly updated) and use the new method SetS3EnableDualstack to enable/disable this option in S3 clients. The code for S3 clients lives here.

There is also a contributing guide if you have more general questions.

[sid-jar]

@mapno, firstly thanks for the suggestion, but a further question being.. we have disabled minio explicitly to be used with tempo. So does tempo use minio internally to compact and send blocks over to s3 ??

[mapno]

No, we use minio-go, which is a "client SDK for S3 compatible object storage". It's just a library to connect to S3-compatible backends.

[Shreyank031]

@mapno The s3DualstackEnabled bool is not added/updated on the vendor packages (api.go). But on the minio source code, we can see s3DualstackEnabled bool in struct. Could this create the conflict when we try to enable it by force ??

[mapno]

I'm not sure I understand what you mean.

S3 dualstack endpoints are configured via the method (function) SetS3EnableDualstack

[mapno]

Hi. Yes, you're welcomed to open a new PR or continue this one #3721. I believe I've explained what needs to be done in the multiple comments in the PR (see #3721 (comment)). Thanks!