Comments (3)
I can confirm I'm seeing the same thing on tip of main:
Is it expected to be able to unmarshal the query responses in
TracesData
...
Yes, this is our intention. Thank you for pointing out the gap.
For the most part we use OTel proto and the json it produces directly. So we are mostly OTel compatible. The gap is right here:
Lines 225 to 227 in b29d56c
The good news is that I've been wanting to rev the traces endpoint for awhile now, but never had the time. I propose we create an /api/v2/traces
with at least the following changes (I'm open to suggestions):
- Rename
batches
toresourceSpans
to cover this issue - Nest the trace itself one deeper. This will allow the endpoint to return metadata or other messages alongside it:
{ trace: <otel compatible trace>, ... }
- Stop returning 404 to mean "trace not found". Instead 200 with an empty trace.
from tempo.
@javiermolinar , thanks a lot for your PR!
Is my understanding correct that your PR makes the internal proto definitions OTEL compatible with the rename from batches
to resourceSpans
but that when querying the current traces
API the JSON output will still return batches
?
If that is true, I think this issue should be kept open a bit longer until there is a new API endpoint that returns fully compatible OTEL JSON output.
from tempo.
Is my understanding correct that your PR makes the internal proto definitions OTEL compatible with the rename from
batches
toresourceSpans
but that when querying the currenttraces
API the JSON output will still returnbatches
?
You are right @siebeclaes. I'm currently working on that #3912
from tempo.
Related Issues (20)
- Guidance on traceql metrics timeout issue
- Support EKS Pod Identity feature HOT 4
- Bug in wal.go causes c.BlocksFilepath config to be overwritten in tempo.yaml HOT 5
- compile issue when make vendor-check HOT 2
- No query results for older telemetry HOT 3
- Tenant error when S3 bucket analytics turned on for S3 backend storage bucket HOT 1
- [DOC] Clarify endpoint access for consistent hash rings doc
- generator push to prometheus pushgateway always fails "HTTP status 400 Bad Request: snappy: corrupt input" HOT 2
- [DOC] Review and update the Parquet docs
- AWS S3 HTTP 4xx client errors HOT 13
- Adjust client/server span times to account for clock skew HOT 3
- Error on kubernetes (microk8s) with persistence enabled HOT 7
- Data retention for 30 days in grafana tempo do not work HOT 5
- User-configurable overrides refuses span-metrics-size as valid processor
- tempo-distributed does not support OpenShift installation out of the box because of missing securitycontextconstraint HOT 2
- aws s3 storage backend:List HOT 2
- pusher failed to consume trace data due to "context canceled" HOT 2
- Monolithic deployment with s3 storage fails with "mkdir /var/tempo/wal: permission denied" HOT 1
- Periodic errors during searching for traces HOT 1
- [DOC] Release notes for 2.6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tempo.