Comments (12)
👍 That's exactly what I had in mind
from grafeas.
Should it be possible to create notes/occurrences for projects that doesn't already exist?
from grafeas.
It should not, the Grafeas storage layer should check for existence of project prior to creating a note/occurrence. This can be handled using a projects db table (which is probably the easiest way to do this for the reference implementation).
from grafeas.
Db table? But there is no database in the reference implementation at this point. Right?
from grafeas.
I'm using the term database loosely :) We should have a separate map for projects in the storage layer.
from grafeas.
That is quite loose 😄
A map we can do. How about a map[string]bool to emulate a set (as we don't have anything but projectId which would then be the key)?
from grafeas.
I have implemented the storage layer (https://github.com/furuholm/Grafeas/tree/project-crud). I guess that there is not much more to do before #50 has been completed?
from grafeas.
@R2wenD2 I have rebased my project-crud branch on top of #79 (https://github.com/combient/Grafeas/tree/project-crud). Will look at the API next. What steps are involved in generating the code?
EDIT: Never mind. Found the command in the Makefile.
from grafeas.
@R2wenD2 I have implemented the API as well. I guess you prefer a PR once you have merged #79 into master?
from grafeas.
@furuholm a PR once #79 is merged would be great :) After we get them both in I'll regen the client libs.
from grafeas.
@furuholm I believe this is done now - is anything remaining?
from grafeas.
It's done so you can close this issue.
from grafeas.
Related Issues (20)
- Running GET cURL for a valid occurrence ID but from the wrong project HOT 1
- json: cannot unmarshal object when trying to create in toto occurrence HOT 4
- [Question]: Getting started with Grafeas HOT 3
- [Question] process to contribute a new storage implementation HOT 2
- Diagram in the readme is unviewable in GH dark mode
- Update Note and Occurrence Protos to support SBOM (SPDX) data HOT 1
- Can't get any notes using python client HOT 1
- [Getting Started] SOS When I visit the grafeas-server, it shows 500
- Support git as one of the producers when sending data to Grafeas HOT 1
- Add support for CWE field in vulnerability proto message HOT 7
- Updating repeated fields is broken due to grpc-gateway bug HOT 1
- Unable to create any occurrence except kind: DEPLOYMENT with postgres backend HOT 1
- Release v0.2.1 HOT 1
- Use Grafeas v1 API HOT 1
- Note ID can be created with / in the id, but not queried HOT 1
- Security Policy violation Binary Artifacts HOT 2
- Enable Grafeas to store and retrieve Vex information
- Support SLSA v1.0 provenance format HOT 1
- possible SQL injection?
- New release for grafeas? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grafeas.