GithubHelp home page GithubHelp logo

Comments (12)

R2wenD2 avatar R2wenD2 commented on June 26, 2024 2

👍 That's exactly what I had in mind

from grafeas.

furuholm avatar furuholm commented on June 26, 2024

Should it be possible to create notes/occurrences for projects that doesn't already exist?

from grafeas.

R2wenD2 avatar R2wenD2 commented on June 26, 2024

It should not, the Grafeas storage layer should check for existence of project prior to creating a note/occurrence. This can be handled using a projects db table (which is probably the easiest way to do this for the reference implementation).

from grafeas.

furuholm avatar furuholm commented on June 26, 2024

Db table? But there is no database in the reference implementation at this point. Right?

from grafeas.

R2wenD2 avatar R2wenD2 commented on June 26, 2024

I'm using the term database loosely :) We should have a separate map for projects in the storage layer.

from grafeas.

furuholm avatar furuholm commented on June 26, 2024

That is quite loose 😄

A map we can do. How about a map[string]bool to emulate a set (as we don't have anything but projectId which would then be the key)?

from grafeas.

furuholm avatar furuholm commented on June 26, 2024

I have implemented the storage layer (https://github.com/furuholm/Grafeas/tree/project-crud). I guess that there is not much more to do before #50 has been completed?

from grafeas.

furuholm avatar furuholm commented on June 26, 2024

@R2wenD2 I have rebased my project-crud branch on top of #79 (https://github.com/combient/Grafeas/tree/project-crud). Will look at the API next. What steps are involved in generating the code?

EDIT: Never mind. Found the command in the Makefile.

from grafeas.

furuholm avatar furuholm commented on June 26, 2024

@R2wenD2 I have implemented the API as well. I guess you prefer a PR once you have merged #79 into master?

from grafeas.

R2wenD2 avatar R2wenD2 commented on June 26, 2024

@furuholm a PR once #79 is merged would be great :) After we get them both in I'll regen the client libs.

from grafeas.

R2wenD2 avatar R2wenD2 commented on June 26, 2024

@furuholm I believe this is done now - is anything remaining?

from grafeas.

furuholm avatar furuholm commented on June 26, 2024

It's done so you can close this issue.

from grafeas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.