Comments (6)
You are right. I commented the lines out because of performance issues with big datasets. I have different ideas to solve that problem:
- We could tell the watcher only to check small datasets and to be disabled for big ones.
- We can remove the option and as I did already for big datasets set some flag in the options to update the chart.
What would you prefer?
from angular-chart.
From the perspective of the digest cycle I don't think the size of the dataset matters as much as the rate of change - does it ?
It feels more angular to have the graph update automatically with perhaps an option to disable that behaviour and a way to then trigger a manual update if you need it ?
My own dataset is pretty small - less than 100 points - so I'd prefer the automatic updates :-)
from angular-chart.
OK, I will add the automatic watcher for small datasets in the next release.
The problem with big datasets is that angular has to check all attributes in each $digest cycle for changes to be able to notify when something changed. (see $watch)
from angular-chart.
Yep - I think that will work fine for me. Any idea when this might make a 0.2.4 release ?
from angular-chart.
Now, please check it out and report any problems.
from angular-chart.
Works great! Thanks for the quick fix and update!
from angular-chart.
Related Issues (20)
- charts don't render HOT 1
- some options don't work HOT 2
- Custom Legend Support? HOT 3
- Injecting chart containers HOT 3
- dimensions with predicate?
- Get data on click HOT 2
- Y axis goes below 0 when min is set to 0 and dataset starts at 1 HOT 1
- Is C3s data.xs supported? HOT 2
- request: function for line chart marker color in dimension configuration HOT 2
- Failed to parse x '2016-06-29 04:10:01' to Date object
- How to capture the x axis tick label HOT 1
- chart is not displaying in Chrome browser.
- How to implement on click event on piechart/bar chart using this directive HOT 2
- accesing $scope inside chart.data.onclick event of pie chart HOT 1
- show pie chart on click of bar chart(chart drilldown)
- Chart is generated with black color fill. HOT 2
- scatterplot implementation HOT 2
- Zoom should be called when chart is applicable for it HOT 4
- Move to billboard.js? HOT 1
- npm audit vulnerabilities found in v0.5.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-chart.