Commented out $watch for dataset ? about angular-chart

[maxklenk]

You are right. I commented the lines out because of performance issues with big datasets. I have different ideas to solve that problem:

1. We could tell the watcher only to check small datasets and to be disabled for big ones.
2. We can remove the option and as I did already for big datasets set some flag in the options to update the chart.

What would you prefer?

[awk]

From the perspective of the digest cycle I don't think the size of the dataset matters as much as the rate of change - does it ?

It feels more angular to have the graph update automatically with perhaps an option to disable that behaviour and a way to then trigger a manual update if you need it ?

My own dataset is pretty small - less than 100 points - so I'd prefer the automatic updates :-)

[maxklenk]

OK, I will add the automatic watcher for small datasets in the next release.

The problem with big datasets is that angular has to check all attributes in each $digest cycle for changes to be able to notify when something changed. (see $watch)

[awk]

Yep - I think that will work fine for me. Any idea when this might make a 0.2.4 release ?

[maxklenk]

Now, please check it out and report any problems.

[awk]

Works great! Thanks for the quick fix and update!