Comments (8)
@vishal24tuniki your thoughts on this? As I believe you're using the changes in #40 and #41 ?
from m3u8.
@bradleyfalzon Yes i am using changes in #40 and #41
I will definitely go through the documentation and come back to you. Been pretty busy the last month or 2
from m3u8.
Thanks, I'd like to maintain ABI, and considering there's a few different SCTE formats, a short term pain by coming up with a more flexible interface maybe a better idea. Although, I think we can reuse much of the existing getters and setters.
from m3u8.
Ideally, we'd be able to read all types of SCTE-35 formats, manipulate them with a single API internally and be able to write in all formats but having the user select which one (by default using HLS RFC EXT-X-DATERANGE method).
To do this properly, it's likely we'd break the existing functionality, but I haven't thought it through, how it would break it, or how long we can maintain the old functionality.
See #61 for the format I initially need to add support for.
This is still an ongoing issue, no changes will be made yet.
from m3u8.
OK, my initial proposal is in #61 - @vishal24tuniki this has a few breaking changes, I'm not convinced it'll be merged as is, but if this doesn't break your use of the library and @grafov is OK with it, I'd like to merge it as is (with the breaking changes).
The breaking changes aren't important, so happy either way, it's just renaming SCTE
to SCTE35
, but it is more correct and specific.
The new support should continue to work with existing SCTE-35 formats, but if you (@vishal24tuniki) could switch to the the newer SetSCTE35()
method (if you're using SetSCTE()
at all), that'd be ideal. See the source for SetSCTE
for the necessary changes.
from m3u8.
We're using this revision quite successfully, and I'd like to consider merging these changes. If anyone wants more time to review and provide feedback that's fine, really I just want to know whether the backwards incompatible changes are acceptable, and if not (that's fine it's just renaming SCTE to SCTE35), we'll just remove those.
from m3u8.
@vishal24tuniki do you have any further thoughts on this, I'm not going to merge just yet, but I would like to apply to breaking change (renaming of fields and changing parameters), but it's also not 100% important to do either, so happy to reconsider it.
from m3u8.
@vishal24tuniki I'd love if you have a chance to check out #81, I've removed the breaking changes as it's taken too long to merge now. So I don't think you'll have any issues, but I have deprecated some functions that you'll need to switch over one day.
from m3u8.
Related Issues (20)
- Using for range loop to MediaPlaylist.Segments would lead to nil pointer dereference HOT 2
- Fix a report card issues for passing to awesome-go list HOT 1
- M3U8 doesn't play after some time HOT 1
- EXT-X-MEDIA audio missing from VariantParams.Alternatives for master playlist decode HOT 1
- . HOT 2
- MediaPlaylist decode custom tag panic
- m3u8.DecodeFrom panics in case of blank lines in playlist
- I have a SCTE-35 parser...... HOT 1
- SCTE35 - EXT-OATCLS-SCTE35 with EXT-X-CUE-IN
- tag: #EXT-X-MEDIA attribute: CHANNELS is not recognized HOT 1
- Is this repo dead? HOT 3
- program panic when i get the url of media segments HOT 6
- safari play fail bug
- Doesn't handle "Alternatives" correctly inside a master playlist's "variants"
- program panic when I parse the media segments
- Decoding MediaPlaylist panics with error: index out of range [0] with length 0 HOT 2
- Support Tag #EXT-X-IMAGE-STREAM-INF
- set Segment key error
- Duplicate Data Resulting from Custom Tags HOT 2
- move away from RegExp
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from m3u8.