GithubHelp home page GithubHelp logo

Comments (8)

bradleyfalzon avatar bradleyfalzon commented on July 29, 2024

@vishal24tuniki your thoughts on this? As I believe you're using the changes in #40 and #41 ?

from m3u8.

vishal24tuniki avatar vishal24tuniki commented on July 29, 2024

@bradleyfalzon Yes i am using changes in #40 and #41
I will definitely go through the documentation and come back to you. Been pretty busy the last month or 2

from m3u8.

bradleyfalzon avatar bradleyfalzon commented on July 29, 2024

Thanks, I'd like to maintain ABI, and considering there's a few different SCTE formats, a short term pain by coming up with a more flexible interface maybe a better idea. Although, I think we can reuse much of the existing getters and setters.

from m3u8.

bradleyfalzon avatar bradleyfalzon commented on July 29, 2024

Ideally, we'd be able to read all types of SCTE-35 formats, manipulate them with a single API internally and be able to write in all formats but having the user select which one (by default using HLS RFC EXT-X-DATERANGE method).

To do this properly, it's likely we'd break the existing functionality, but I haven't thought it through, how it would break it, or how long we can maintain the old functionality.

See #61 for the format I initially need to add support for.

This is still an ongoing issue, no changes will be made yet.

from m3u8.

bradleyfalzon avatar bradleyfalzon commented on July 29, 2024

OK, my initial proposal is in #61 - @vishal24tuniki this has a few breaking changes, I'm not convinced it'll be merged as is, but if this doesn't break your use of the library and @grafov is OK with it, I'd like to merge it as is (with the breaking changes).

The breaking changes aren't important, so happy either way, it's just renaming SCTE to SCTE35, but it is more correct and specific.

The new support should continue to work with existing SCTE-35 formats, but if you (@vishal24tuniki) could switch to the the newer SetSCTE35() method (if you're using SetSCTE() at all), that'd be ideal. See the source for SetSCTE for the necessary changes.

from m3u8.

bradleyfalzon avatar bradleyfalzon commented on July 29, 2024

We're using this revision quite successfully, and I'd like to consider merging these changes. If anyone wants more time to review and provide feedback that's fine, really I just want to know whether the backwards incompatible changes are acceptable, and if not (that's fine it's just renaming SCTE to SCTE35), we'll just remove those.

from m3u8.

bradleyfalzon avatar bradleyfalzon commented on July 29, 2024

@vishal24tuniki do you have any further thoughts on this, I'm not going to merge just yet, but I would like to apply to breaking change (renaming of fields and changing parameters), but it's also not 100% important to do either, so happy to reconsider it.

from m3u8.

bradleyfalzon avatar bradleyfalzon commented on July 29, 2024

@vishal24tuniki I'd love if you have a chance to check out #81, I've removed the breaking changes as it's taken too long to merge now. So I don't think you'll have any issues, but I have deprecated some functions that you'll need to switch over one day.

from m3u8.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.