GithubHelp home page GithubHelp logo

Comments (7)

APJansen avatar APJansen commented on July 28, 2024 1

With poetry we probably want to make the rnn dependencies optional, as they are quite heavy (mainly tensorflow).

from grainlearning.

APJansen avatar APJansen commented on July 28, 2024 1

Another todo: generate the documentation, and probably for that to work we have to pick one convention for docstrings as currently we're using different ones.

from grainlearning.

APJansen avatar APJansen commented on July 28, 2024

I manually updated pyproject.toml adding the rnn dependencies. For the versions I checked what the latest was and used that, but that might not be necessary. Then ran poetry lock --no-update to add these to the lock file without upgrading versions of other packages. Then tested installing with poetry install, but there is an issue with tensorflow, specifically: Unable to find installation candidates for tensorflow-io-gcs-filesystem (0.27.0) (related issue)
Likely this is because I'm on a (arm) mac, replacing tensorflow with tensorflow-macos fixed it for me, everything now installs. But this needs to be fixed for everyone somehow..

from grainlearning.

APJansen avatar APJansen commented on July 28, 2024

It runs now, as long as the data is present at grainlearning/rnn/data/sequences.hdf5. Wandb creates a folder inside rnn/.

from grainlearning.

luisaforozco avatar luisaforozco commented on July 28, 2024

We picked the following convention for docstrings:

  • Use python type hints.
  • Use sphinx format for docstrings, specifically:
    :param : and :return :, we are dropping :type : and :rtype:

from grainlearning.

luisaforozco avatar luisaforozco commented on July 28, 2024

Regarding the dependencies, In this commit I created two groups of extras rnn and rnn_M1_macOS with the necessary dependencies (only difference is in tensorflow).
I tested in my machine poetry install -E rnn_M1_macOS and on Snellius poetry install -E rnn, and the dependencies are handled correctly.

from grainlearning.

luisaforozco avatar luisaforozco commented on July 28, 2024

The installation of tensorflow for arm64 macOS requires some extra steps that cannot be handled from poetry. I think the best is to keep it separately: if an user has M1 macOS he/she will have to install tensorflow first on his own, and then he/she can install grainLearning on the same python environment.

from grainlearning.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.