GithubHelp home page GithubHelp logo

Comments (7)

RamyaMylavarapu avatar RamyaMylavarapu commented on July 30, 2024

Screen Shot 2020-02-04 at 12 38 54 PM

from comicgen.

sanand0 avatar sanand0 commented on July 30, 2024

Cool. @tejesh95 is this fine for you? If yes, we can move on to Dee. @RamyaMylavarapu I can test Dee.

from comicgen.

tejesh0 avatar tejesh0 commented on July 30, 2024

Examples: Evan AngryFrustrated and Ava AngryFrustrated does not have classes and still use fill attributes.

For time being, let's suppose classes are generated from Illustrator correctly.

Even if so, there is an edge case to be handled. Body svg of Evan will have a class .st1 { fill: 'brown'} but autogenerated class name from Illustrator for Face svg of Evan can contain the same classname assigned in <svg><style>.st1 {fill: 'darkbrown'} </style> </svg>

Two different SVGs having same class names loaded in same page will override one of them.

from comicgen.

RamyaMylavarapu avatar RamyaMylavarapu commented on July 30, 2024

Anand, I exported two Dee's emotions. Pls let me know which works better. https://cloud.gramener.com/d/9dc55360b6d749309b1f/

from comicgen.

sanand0 avatar sanand0 commented on July 30, 2024

Here are anomalies I see. I just randomly changed the class colors and this is the result. Here is the SVG: deeface1.zip

image

@RamyaMylavarapu please revise the images to ensure that there's one color each for:
the face fill, the face outline, the hair, and the shadows. I don't think we need more colors.

@tejesh95 We can parametrize just the face fill and the hair.

from comicgen.

sanand0 avatar sanand0 commented on July 30, 2024

Same problems with deeface2.zip:

image

from comicgen.

sanand0 avatar sanand0 commented on July 30, 2024

Done with Comicgen v1

from comicgen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.