checkstyle 8.26 checkstyle/checkstyle.xml ruleset blocks building ongdb about ongdb

[alexiudice]

You can disable the checkstyling using the maven option -Dcheckstyle.skip=true

Try running this maven command to build up to the verify stage:

mvn clean verify -DfullBuild -Dlicense.skip=true -Dcheckstyle.skip=true -Dscalastyle.skip=true -DcreateChecksum=true -DskipTests

[jsoref]

That works:

[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  28:13 min
[INFO] Finished at: 2020-03-04T15:01:33-05:00

But it isn't documented anywhere. (It's now documented in your comment, which is slightly better than nothing.)

If people don't have something specifically against the checkstyle checks, I'd rather merge fixes for them (see #20). And if people are absolutely opposed to checkstyle checks, then the build system should be adjusted so that it doesn't enforce them.

[bradnussbaum]

@jsoref I started a branch (3.5-checkstyle) for fixing up the checkstyle issues. Did your commit resolve all of the checkstyle issues or just a few? I am building through now. If it resolves all of them then we can remove the -Dcheckstyle.skip=true flag from the build server so that it stays fixed. Will be nice to have this cleaned up.

[jsoref]

Hmm, I was running mvn install -rf :... and kept progressing the target as it failed until it stopped failing.

My naive assumption is that means it's finished. But I could be wrong if there are some code paths beyond mvn install or if -rf :... happens to not do what I'm expecting.

[bradnussbaum]

That should be right. I have build going now with the flag -Dcheckstyle.skip=true removed.

https://bamboo.graphfoundation.org/browse/ONGDB-ONGDB52-2

[jsoref]

Fwiw, I'm a bit puzzled by dade943 by @jmsuhy