GithubHelp home page GithubHelp logo

Comments (7)

ratrun avatar ratrun commented on June 1, 2024 1

Currently we are treating access=no and vehicle=no the same way with allowing this segment for bicycles. But according to https://wiki.openstreetmap.org/wiki/Tag:access%3Dno the intention of access=no is stronger. While on a segment tagged as vehicle=no it is still possible and legal to dismount and push for access=no this is not the case. So I think that this problem report is valid and we should change it. I'm going to prepare a PR if there aren't any objections.

from graphhopper.

karussell avatar karussell commented on June 1, 2024 1

Have also thought about this like using foot_access in a custom model as exception when bike_access is false but there are several cases where is does not work like for steps or bad surfaces or a too big hike_rating (sac_scale) etc.

from graphhopper.

karussell avatar karussell commented on June 1, 2024

See discussion in #870. Maybe @ratrun can comment on this.

Anyway, the discussion about the tagging above is valid. I'm going to prepare a change to accept highway=cycleway toghether with vechicle=no. We should allow this for bicyles. Cycleways under construction should be tagged with with highway=construction

from graphhopper.

bt90 avatar bt90 commented on June 1, 2024

Access parsing aside, the road isn't tagged properly IMHO. This should be highway=construction + construction=cycleway as explained in the OSM wiki:

https://wiki.openstreetmap.org/wiki/Tag:highway%3Dconstruction#How_to_map_the_start_of_a_road_repair_or_reconstruction

from graphhopper.

karussell avatar karussell commented on June 1, 2024

And should we remove the special case way.hasTag("highway", "cycleway")) in BikeCommonAccessParser? And then consider the "dismount" for vehicle=no in OSMGetOffBikeParser and BikeCommonAverageSpeedParser?

from graphhopper.

ratrun avatar ratrun commented on June 1, 2024

And should we remove the special case way.hasTag("highway", "cycleway"))

I extended the check there in my first version of the PR, see #2981

And then consider the "dismount" for vehicle=no in OSMGetOffBikeParser and BikeCommonAverageSpeedParser?

Yes that is a good idea. I'll try to extend the PR.

from graphhopper.

bt90 avatar bt90 commented on June 1, 2024

And then consider the "dismount" for vehicle=no

Broadly speaking, we should do this for all cases where foot access is allowed but biking isn't.

from graphhopper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.