GithubHelp home page GithubHelp logo

Comments (3)

chentsulin avatar chentsulin commented on May 8, 2024

Hi @entropitor
Could you write a failed test to demonstrate this issue?
Now, there is a test shows that it response stats 400 when receive validation error:
https://github.com/chentsulin/koa-graphql/blob/7b4d23aecf5926c9b0181d6e9e775d2a1357c9d1/src/__tests__/http-test.js#L201-L225

from koa-graphql.

entropitor avatar entropitor commented on May 8, 2024

@chentsulin You are testing the validations on the query, then it correctly returns a 400, but if there is a validation error on the variables (e.g. the value of a variable not matching the given type) then it returns a 200.

I can see if I can write a test myself soon

from koa-graphql.

chentsulin avatar chentsulin commented on May 8, 2024

The codebase has been changed a lot, so this might not be reproduced anymore.

from koa-graphql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.