GithubHelp home page GithubHelp logo

Comments (5)

GraylinKim avatar GraylinKim commented on September 6, 2024

All these s2gs parsing problems should be fixed at this point. Reopen if you disagree.

from sc2reader.

dsjoerg avatar dsjoerg commented on September 6, 2024

That word "should" scares me. Did you try parsing the s2gs files corresponding to the hashes I sent when this issue was opened?

from sc2reader.

GraylinKim avatar GraylinKim commented on September 6, 2024

Sorry, I should be more affirmative with my language!

Anyway, I went back over all the s2gs files on my possession and confirmed the fix. I also found and fixed a couple weird issues with settings in s2gs files for custom maps in 32297ce and 92ed828. I also confirmed that all your integration tests passed before and after the changes. s2gs should be good to go!

from sc2reader.

dsjoerg avatar dsjoerg commented on September 6, 2024

BOOM

from sc2reader.

dsjoerg avatar dsjoerg commented on September 6, 2024

Ha, you managed to sneak a "should" in the beginning and the end of your "affirmative" language. You should be ashamed!

from sc2reader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.