greenm01 / porc Goto Github PK

Hi there, 1st of all thanks for this awesome work !

Since we've 'doxed' it in our HyMPS project (under AUDIO section \ Treatments page \ Digital Room Correction), can you please add a GH-compliant license file for it ?

As you know, expliciting licensing terms is extremely important to let anyone better/faster understand how to reuse/adapt/modify sources (and not only) in other open projects and vice-versa.

Although it may sounds like a minor aspect, license file omission obviously causes an inconsistent generation of the relative badge too:

(badge-generator URL: https://badgen.net/github/license/greenm01/porc)

You can easily set a standardized one through the GH's license wizard tool.

Last but not least, let us know how we could improve - in your opinion - our categorizations and links to resources in order to favor collaboration between developers (and therefore evolution) of listed projects.

Hope that helps/inspires !

Hi :)
First of all, thank you for your excellent software.

It seems that, as by now, it does not make use of the microphone's calibration file. Am I wrong ?

Since REW exports impulse responses without mic calibration, it would be nice to support it on the PORC side. Could that be possible ?

If led in the right direction, I would also be happy to help.

Hello,
I'm trying to get this going with Anaconda2 v5.1.0. However, lots of stuff seems incorrect. For example, scipy.stats no longer has the nanstd function (afaik it never has) and nanstd is a numpy replacement. I can make a PR for that. One other thing that prevents me from executing is an issue creating IIR filters, it breaks on calling sig.butter:

Traceback (most recent call last):
  File "porc.py", line 374, in <module>
    main()  
  File "porc.py", line 371, in main
    roomcomp(args.impresp, args.filter, args.target, args.ntaps, args.mixed, args.opformat, args.trim, args.nsthresh, args.noplot)
  File "porc.py", line 152, in roomcomp
    Bf, Af = sig.butter(4, 30/(Fs/2), 'high')
  File "/opt/anaconda2/lib/python2.7/site-packages/scipy/signal/filter_design.py", line 2394, in butter
    output=output, ftype='butter')
  File "/opt/anaconda2/lib/python2.7/site-packages/scipy/signal/filter_design.py", line 1959, in iirfilter
    raise ValueError("Digital filter critical frequencies "
ValueError: Digital filter critical frequencies must be 0 < Wn < 1

I would really love to get mixed-phase filters on my system so if I can help I'd love to do so. I'm going to try to find the exact scipy version with nanstd and work from the Anaconda release that included it.