GithubHelp home page GithubHelp logo

Comments (6)

gilsdav avatar gilsdav commented on May 27, 2024 2

@ShrikantAdhav I released a new version for Angular 7. Can you try with "localize-router-lazy-universal-module-loader": "1.0.1" ?

from localize-router.

SolveWithShri avatar SolveWithShri commented on May 27, 2024

@meeroslav Any input on this ?
Thanks!

from localize-router.

youtpout avatar youtpout commented on May 27, 2024

Hello seems to work if you use children and not load children

import { NgModule } from '@angular/core';
import { RouterModule, Routes } from '@angular/router';
import { Location } from '@angular/common';

import { DashboardComponent } from './dashboard/dashboard.component';
// import { HeroesComponent } from './heroes/heroes.component';
import { HeroDetailComponent } from './hero-detail/hero-detail.component';
import { HeroesComponent } from "./heroes/heroes.component";

import { LocalizeRouterModule, LocalizeRouterSettings, LocalizeParser, ManualParserLoader } from 'localize-router';
// import { LocalizeRouterHttpLoader } from '@gilsdav/ngx-translate-router-http-loader';
import { TranslateService } from '@ngx-translate/core';
import { GotLostPageComponent } from './got-lost-page/got-lost-page.component';

/* export function createTranslateLoader(translate: TranslateService, location: Location, settings: LocalizeRouterSettings, http: HttpClient) {
return new LocalizeRouterHttpLoader(translate, location, settings, http)
} */

export function createTranslateLoader(translate: TranslateService, location: Location, settings: LocalizeRouterSettings,) {
return new ManualParserLoader(translate, location, settings, ['en', 'fr'], 'ROUTES.');
}

const child: Routes = [
{ path: "", redirectTo: "home", pathMatch: "full" },
{ path: "home", component: HeroesComponent }
];

const routes: Routes = [
{ path: '', redirectTo: '/dashboard', pathMatch: 'full' },
{ path: 'dashboard', component: DashboardComponent },
{ path: 'detail/:id', component: HeroDetailComponent },
{ path: 'heroes', children: child },
{ path: '**', component: GotLostPageComponent }
];

@NgModule({
imports: [
RouterModule.forRoot(routes),
LocalizeRouterModule.forRoot(routes, {
parser: {
provide: LocalizeParser,
useFactory: (createTranslateLoader),
deps: [TranslateService, Location, LocalizeRouterSettings/, HttpClient/]
}
})
],
exports: [ RouterModule, LocalizeRouterModule ]
})
export class AppRoutingModule {}

from localize-router.

gilsdav avatar gilsdav commented on May 27, 2024

Hello @ShrikantAdhav ,
Sorry for the late response.

If I undersand, you have forked my repo and replaced every ngx-translate-router by localize-router.

Please refer to https://github.com/gilsdav/universal-localize-module-loader ReadMe.

If you use localize-router => 1.0.0
If you use ngx-translate-router => 1.0.0-ntr

ntr suffix is for Ngx-Translate-Router

So replace "localize-router-lazy-universal-module-loader": "1.0.0-ntr" by "localize-router-lazy-universal-module-loader": "1.0.0"

If it doesn't work with new version of localize-router, fill free to open issue on this repo.

Edited

universal-localize-module-loader generate an error on build with new version of module-map-ngfactory-loader.
In created an issue and will deploy a new version soon gilsdav/universal-localize-module-loader#3

from localize-router.

hohler avatar hohler commented on May 27, 2024

I think it's working now, but somehow the rendered page flickers and "reloads" in the browser. This is just when it's a lazy loaded module.

Configuration:

// Actually, the flickering is also with your example https://github.com/gilsdav/angular-universal-localize-router (Angular 7)

To hopefully disable the flickering, "initialNavigation" could be set, but this is an other issue #157 here

from localize-router.

SolveWithShri avatar SolveWithShri commented on May 27, 2024

Thanks @gilsdav For the support :)

As mentioned by @hohler that its working, i am closing the issue.

from localize-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.