Comments (11)
You are right, go ahead with the PR.
from toasty.
If you don't mind, I can do that
from toasty.
What do you mean with 2.
?
from toasty.
ping @programmerr47
from toasty.
@GrenderG Hi. Sorry for such delay.
I mean next:
private int DEFAULT_TEXT_COLOR = Toasty.DEFAULT_TEXT_COLOR;
Here is an example of a config field. Since it is written in ALL_CAPS_SNAKE_CASE and it is a common practice for naming constants, you may not notice lack of static final
keywords and thus erroneously assume, that it is a constant.
Situation is become more obscure, when you see, that:
private static int DEFAULT_TEXT_COLOR = Color.parseColor("#FFFFFF");
is not just a field of an object, but a field of a class, written in a constant style
See jls for more information. For more easy search page 138, item Field Names :)
from toasty.
Hi, im working on that.
Should I continue supporting to change default color by Toasty.Config? Or should it be done entirely from resources?
from toasty.
Just tell me what do you want your library to do and I will implement it :)
@GrenderG
from toasty.
I'm just not sure about how to implement this. I don't want to remove support for @ColorInt
, but I know that it would be good to exclude default color variables to resources and / or support theming via color resources, although this can actually be done at this moment using getColor(...)
/ ContextCompat.getColor(...)
methods.
What do you guys think?
from toasty.
Have a look to the way I implement it, it is now by default getting default color from resources but it is also posible to override them throught the config at run time.
Maybe we shouldn't give an option to override default colors at run time and instead the developers would use Toasty.custom (?)
from toasty.
Maybe we shouldn't give an option to override default colors at run time and instead the developers would use Toasty.custom (?)
Okay! I agree with this.
from toasty.
Maybe we shouldn't give an option to override default colors at run time and instead the developers would use Toasty.custom (?)
Okay! I agree with this.
Done! Have a look at it and tell me what you think 😄
#93
from toasty.
Related Issues (20)
- An error occurs when getting the icon in the component.
- ToastUtil 简单封装
- 内存泄漏问题
- I'm getting error Failed to resolve: com.github.GrednerG:Toasty:1.4 HOT 4
- ToastyUtils.java line 1 es.dmoral.toasty.ToastyUtils.getDrawable HOT 2
- andy
- Feature request: support text shadow - TextView.setShadowLayer(float radius, float dx, float dy, int colour) HOT 1
- NullPointerException 想请问下这个空指针异常是由于什么原因造成的
- ColorHub - Color Palette no longer exists on g play
- memory leak HOT 1
- normal状态下的Toast白底黑字,normalWithDarkThemeSupport这个方法能否优化一下
- Show multiple toast at same time vertical
- Migration to mavencentral HOT 2
- Duration longer than Toast.LENGTH_LONG? HOT 2
- It didn't work HOT 1
- App Promotion
- leak
- leaks 内存泄漏 HOT 1
- How to solve Memory leak
- is this lib deprecated in android API 34? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from toasty.