GithubHelp home page GithubHelp logo

Improve network block about i3status-rust HOT 6 CLOSED

greshake avatar greshake commented on August 14, 2024
Improve network block

from i3status-rust.

Comments (6)

greshake avatar greshake commented on August 14, 2024

@etrombly did the net block, maybe he wants to help you out :)

from i3status-rust.

etrombly avatar etrombly commented on August 14, 2024

Shouldn't be too hard to add the ip. I didn't add it originally because there isn't a standard for formatting across blocks, it's handled at the block level, so I was waiting to see if anything was created for that. @greshake if I send an empty vec back for the view function will the block not be drawn at all? If not I can just change the status.

from i3status-rust.

greshake avatar greshake commented on August 14, 2024

Correct, it will not be displayed.
See util.rs:99:

        let widgets = block.view();
        if widgets.len() == 0 {
            continue;
        }

from i3status-rust.

atheriel avatar atheriel commented on August 14, 2024

@greshake @etrombly Any objection to my upstreaming some related changes to the Net block? It would add these features.

from i3status-rust.

etrombly avatar etrombly commented on August 14, 2024

I don't have a problem with it. Anything to improve it is welcome.

from i3status-rust.

greshake avatar greshake commented on August 14, 2024

Sure go ahead

from i3status-rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.