GithubHelp home page GithubHelp logo

Comments (6)

Lakshya2610 avatar Lakshya2610 commented on July 24, 2024

This has been fixed in pull request #51

from toonin.

Lakshya2610 avatar Lakshya2610 commented on July 24, 2024

@alir128 The reason I re-open this issue is we still don't have a system to check if the src for a room still exists. In the event that user doesn't stop streaming and closes chrome directly (or some other unexpected reason for src disconnection), server won't know if the user is still active, even though the room is now inaccessible. Ideally, we should have some sort of ping system to check the status of the room every minute or so

from toonin.

alir128 avatar alir128 commented on July 24, 2024

image

from toonin.

alir128 avatar alir128 commented on July 24, 2024

the functionality already exists since last week, the tabs.onRemoved listener checks once the streaming tab is existed it makes disconnect room call and all clients automatically switch back the state where they can connect to another or host a room.

from toonin.

Lakshya2610 avatar Lakshya2610 commented on July 24, 2024

what if the user closes the window itself instead of just the tab? Maybe we can add a onclose handler?

from toonin.

alir128 avatar alir128 commented on July 24, 2024

I just tested the scenario also (1 tab only on a window which is the host) and connected a client. I exited the host (window not tab) and the clients still received the host logoff message from the server and got reset. So I think the tab listener also works as a window close listener also.

from toonin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.