Comments (12)
i think it was the scoping not accepting :for => :user when I was on admin/sign_in
from devise_facebook_connectable.
OK, thanks, will look into this.
from devise_facebook_connectable.
from devise_facebook_connectable.
Nested trap - is that really a best practice for warden/devise? I didn't see "pass" used in Devise authenticatable module, could you maybe elaborate on why it's needed for facebook_connectable? Feels incorrect when authenticatable is not doing this - should be same-same, right?
from devise_facebook_connectable.
Probably not best practice anywhere, however i need to do this as this strategy is called even when a model (such as my admin model) does not have facebook_connectable. pass is just the same as do nothing and try the next strategy, which is what i want.
The better way to achieve this would be to check if the model responded to facebook_connect then just pass if it doesn't. however I needed to hack this up quick
from devise_facebook_connectable.
OK, cool. Your second suggestion is most probably better. Will look on it when I get some time.
from devise_facebook_connectable.
Warden::Strategies are stored as a hash not an array, which explains why I only occasionally hit this error, as sometimes the normal auth strategy is chosen first
from devise_facebook_connectable.
i'm tired - it's late just looked at warden more closely and the correct place for klass.respond_to?(:facebook_connect)
is in valid?
from devise_facebook_connectable.
from devise_facebook_connectable.
I cannot reproduce this at all, but I posted this in Devise mailing list to be sure.
from devise_facebook_connectable.
This commit "should" solve this:
http://github.com/grimen/devise_facebook_connectable/commit/77d27440b5da3ab7a9edcc209f7d92ba67bbf2fb
Can you clone, build the gem, and try in your project please? I could not re-produce so...
from devise_facebook_connectable.
Hah, the reason I could not re-produce this was that I fixed the issue before I tried it. Didn't know that was the issue by then, so now I could reproduce this and the commit above fixes the issue. Now I'll bump the gem.
from devise_facebook_connectable.
Related Issues (20)
- Connect existing accounts HOT 1
- mongo_mapper throws an error with save_with_validation HOT 3
- callbacks not working for me (MongoMapper) HOT 9
- `include': wrong argument type Class (expected Module) (TypeError) HOT 4
- facebook cookie and auto login problems HOT 20
- facebook_sign_in_link helper causes NoMethodError in Ruby 1.9.1 HOT 5
- How does this work? HOT 5
- sign_out not working with passenger HOT 12
- Devise 1.0.6 breaks facebook_connectable HOT 2
- rails 3.0.0-beta3 and devise 1.1.rc1 HOT 2
- edit user profile question HOT 7
- Facebooker::Session::SessionExpired on User.populate(*fields) HOT 1
- HAML Issues HOT 4
- facebook_sign_out_link always use the user model? HOT 2
- not working after clearing database
- before_facebook_connect(fb_session) HOT 1
- facebook.yml callback_url has wacky side effects HOT 1
- Problem signing out with facebooker 1.0.75 HOT 2
- uninitialized constant ActiveSupport::CoreExtensions (NameError)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from devise_facebook_connectable.