GithubHelp home page GithubHelp logo

Comments (2)

awvwgk avatar awvwgk commented on June 15, 2024

In case of PDB or molfile/SDF input this is useful, since a kind of meta-information about hydrogen atoms is present in the file format (e.g. for a PDB file it is extremely unlikely to encounter a valid input without any hydrogen atoms). For molfile/SDF input it is more difficult, any assumption on the topology or valency of an atom without performing a calculation is out-of-scope for xtb. The hydrogen atom query field can be used to determine if explicit hydrogen atoms are missing and to reject input, but it is not required to be present if no explicit hydrogen atoms are given. A more sophisticated scheme would use the formal charges, topology information and bond orders to check for missing hydrogen atoms, which in my opinion is actually the responsibility of the provider.

For Turbomole coordinates and xyz input this check has to be performed by the provider of the input geometry, xtb should not perform any checks for topology or valency here.

from xtb.

sozenoid avatar sozenoid commented on June 15, 2024

Related to this topic, xtb will refuse to process a molecule supplied in an .pdb format without any hydrogen even when the molecule is valid. An example is hexafluorobenzene which xtb will accept as .sdf format but reject as .pdb. I think adding a warning in an absence of hydrogens is fine but rejecting the input seems a bit too conservative.

  • xtb version 6.3.3 (5b13467) compiled by 'ehlert@majestix' on 2020-09-17

########################################################################
[ERROR] Program stopped due to fatal error
-2- reading geometry input 'testmol2.pdb' failed
-1- io_reader_readMolecule: You get no calculation today, please add hydrogen atoms first
########################################################################

from xtb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.