GithubHelp home page GithubHelp logo

Comments (8)

GeertJohan avatar GeertJohan commented on May 4, 2024 2

Looks like the problem has been solved indeed.
Thanks @domgreen @yifanzz

from go-grpc-middleware.

domgreen avatar domgreen commented on May 4, 2024 1

@GeertJohan will be looking at this this morning

from go-grpc-middleware.

loderunner avatar loderunner commented on May 4, 2024

I have the same issue with interceptors. It is now impossible to mix-and-match grpc_middleware interceptors with grpc interceptors.

server/serve.go:143:37: cannot use i (type "google.golang.org/grpc".UnaryServerInterceptor) as type "github.com/grpc-ecosystem/go-grpc-middleware/vendor/google.golang.org/grpc".UnaryServerInterceptor in argument to grpc_middleware.ChainUnaryServer
server/serve.go:143:37: cannot use grpc_middleware.ChainUnaryServer(i) (type "github.com/grpc-ecosystem/go-grpc-middleware/vendor/google.golang.org/grpc".UnaryServerInterceptor) as type "google.golang.org/grpc".UnaryServerInterceptor in argument to "google.golang.org/grpc".UnaryInterceptor

from go-grpc-middleware.

Kilmar avatar Kilmar commented on May 4, 2024

Same problem here but with Context

have Context() ".../vendor/golang.org/x/net/context".Context
want Context() ".../vendor/github.com/grpc-ecosystem/go-grpc-middleware/vendor/golang.org/x/net/context".Context

from go-grpc-middleware.

chadnickbok avatar chadnickbok commented on May 4, 2024

Oh lawdy please remove these vendored packages. Checking in a lockfile is one thing, but checking in the entire vendor directory is Not The Way.

from go-grpc-middleware.

GeertJohan avatar GeertJohan commented on May 4, 2024

@domgreen could you please look into this?

from go-grpc-middleware.

GeertJohan avatar GeertJohan commented on May 4, 2024

Preferably the master branch is rolled back to 2e3f98d. Afterwards re-apply the commits added since #101 which are: b5293e3 and 952ab2f. This cleans up the ~1.8 milion changes introduced in ab28732.

from go-grpc-middleware.

yifanzz avatar yifanzz commented on May 4, 2024

Merged @domgreen's fix. Let us know if this fixes your issue. @GeertJohan

from go-grpc-middleware.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.