Duplicate peer.address in zap logger output about go-grpc-middleware

[mwitkow]

Interesting. This indeed looks like a bug.

[fangwendong]

https://github.com/grpc-ecosystem/go-grpc-middleware/blob/master/tags/interceptors.go#L70
there needn't peer.addr

[mier85]

I have experienced the same with another tag ( a custom tag ) and peer.address. So I highly suspect that every tag that exists in metadata plus is added to the tags, will be logged twice.

[freddiesunarso]

I have experienced the same thing too with custom tags and peer address

[bobheadxi]

#146 is almost a duplicate of this - I am looking into this @ #166

[freddiesunarso]

I have just found out that the issue only happens when the grpc_ctxtags interceptor comes first in the ChainServer function argument, i.e.

grpcServer := grpc.NewServer(
   grpc.UnaryInterceptor(grpc_middleware.ChainUnaryServer(
      grpc_ctxtags.UnaryServerInterceptor(opts...),
      grpc_zap.UnaryServerInterceptor(zapLogger),
   )),
)

But it does not happen otherwise:

grpcServer := grpc.NewServer(
   grpc.UnaryInterceptor(grpc_middleware.ChainUnaryServer(
      grpc_zap.UnaryServerInterceptor(zapLogger),      
      grpc_ctxtags.UnaryServerInterceptor(opts...),
   )),
)