Comments (14)
@srenatus, since protobuf 1.0.0 did not change any API we use vs our used version, have you try to use https://golang.github.io/dep/docs/Gopkg.toml.html#override in your Gopkg.toml for protobuf to avoid these errors?
from go-grpc-middleware.
I assume this error is related to this issue:
Solving failure: No versions of github.com/grpc-ecosystem/go-grpc-middleware met constraints:
v1.0.0: Could not introduce github.com/grpc-ecosystem/[email protected], as it has a dependency on github.com/golang/protobuf with constraint master, which has no overlap with existing constraint ^1.2.0 from (root)
master: Could not introduce github.com/grpc-ecosystem/go-grpc-middleware@master, as it is not allowed by constraint ^1.0.0 from project github.com/xxx/xxx.
from go-grpc-middleware.
It would be very nice to fix this -- especially with other projects having that constraint, you can quickly run into
Solving failure: No versions of github.com/grpc-ecosystem/go-grpc-middleware met constraints:
master: Could not introduce github.com/grpc-ecosystem/go-grpc-middleware@master, as it has a dependency on github.com/golang/protobuf with constraint master, which has no overlap with the following existing constraints:
^1.0.0 from (root)
^1.0.0 from github.com/lyft/protoc-gen-validate@master
master: Could not introduce github.com/grpc-ecosystem/go-grpc-middleware@master, as it has a dependency on github.com/golang/protobuf with constraint master, which has no overlap with the following existing constraints:
^1.0.0 from (root)
^1.0.0 from github.com/lyft/protoc-gen-validate@master
from go-grpc-middleware.
@mwitkow ive actually been thinking of removing dep and dependancy management from the project ... is an ongoing discussion im having offline with @Bplotka about wether we should even include this for libraries / packages 😄
from go-grpc-middleware.
Switching to ^1.0.0 or anything that supports using a constraint on 1.2.0 would be really helpful - I'm having trouble introducing this dependency as well
from go-grpc-middleware.
master: Could not introduce github.com/grpc-ecosystem/grpc-gateway@master, as it has a dependency on github.com/golang/protobuf with constraint aa810b61a9c79d51363740d207bb46cf8e620ed5, which has no overlap with existing constraint master from github.com/grpc-ecosystem/go-grpc-middleware@master
from go-grpc-middleware.
Yeah, I don't know what their policy is. Hopefully with vgo
being more mainstream all this craziness will go away.
from go-grpc-middleware.
Yea, I am not fan of non-std deps for library, but we have lots of it that are unavoidable, so maybe using dep mngt is actually must-have to ensure users see with what deps we tested against.
First of all before changing anything... Can we do some releases?
from go-grpc-middleware.
@Bplotka Thank you. That's another option indeed. 👍
from go-grpc-middleware.
Hello there,
since #40 is now closed and we have a tagged release, can we match the version in Gopkg.toml
? or you are still discussing about removing dep :D ?
from go-grpc-middleware.
I was thinking... would removal of dep and moving to Go modules would help ?
from go-grpc-middleware.
Switching to ^1.0.0
would probably be easier for now, but its totally up to you all. I'm not using modules yet (waiting on that to be finalized), so whatever doesn't make dep
complain/fail works for me.
from go-grpc-middleware.
@bwplotka there're still many projects that use dep.
It would be nice to support both dep and go modules.
from go-grpc-middleware.
I am not sure if dep is still relevant 4 years later, so closing.
from go-grpc-middleware.
Related Issues (20)
- I want to ignore some defult logged fields HOT 1
- Adding `grpc_code` label to prometheus `grpc_server_handling_seconds` metric HOT 5
- With HOT 1
- Logging interceptor does not correctly log client calls sent from a server HOT 4
- Support for connect go HOT 5
- "make test" and "make lint" ignore failures
- Support for WithSubsystem() HOT 5
- [retry-middleware] Stream is finished when retry timeout ends HOT 2
- Support loggging grpc status details HOT 1
- Add source and target endpoint as label for all client/server grpc metrics HOT 2
- Support ignore logging for v2(already attached PR) HOT 3
- Prometheus metrics label value inconsistency between Go and Java HOT 3
- [logging] disable option does not work with request/response fields HOT 6
- go-grpc-middleware/providers/openmetrics/v2 v2.0.0-rc.3 dependency of go-grpc-middleware/v2 v2.0.1 broken HOT 8
- Q: Logger migration HOT 2
- Support extensibility of retry condition
- [feat]: logging should loging grpc request msg HOT 1
- Example will log only first field HOT 3
- Add Capability to Override Base Timeout for Specific API HOT 1
- Use retry hooks for adding retry metrics
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-grpc-middleware.