Comments (4)
The log entry is then cloned every time on new request and the clone is put inside the Context
variable of the request. That request is then handled by the dispatching goroutine. Most request handling is done in a single synchronous block, and unless someone dispatches more goroutines from it, it is safe.
Any concerns around that?
from go-grpc-middleware.
Has this been a conscious decision? It is not uncommon to open new goroutines in a single request. Like you said most request handling is done in a single synchronous block. Logging in this way would force you to adopt two logging approaches, one for in the main request thread and one for the child threads.
from go-grpc-middleware.
Yes, this was a concious decision. In our codebase, whenever we fan out to sub to go routines (rare) we make sure that we clone the relevant objects and pass them explicitly.
Would you like to contribute documentation clarification around this?
from go-grpc-middleware.
This is pretty old and we know have v2
code with different structure. Let us know if this is still important, we can reopen.
from go-grpc-middleware.
Related Issues (20)
- When will a V2 be released? HOT 4
- How is the `logging.InjectLogField` supposed to work? HOT 2
- I want to ignore some defult logged fields HOT 1
- Adding `grpc_code` label to prometheus `grpc_server_handling_seconds` metric HOT 5
- With HOT 1
- Logging interceptor does not correctly log client calls sent from a server HOT 4
- Support for connect go HOT 5
- "make test" and "make lint" ignore failures
- Support for WithSubsystem() HOT 5
- [retry-middleware] Stream is finished when retry timeout ends HOT 2
- Support loggging grpc status details HOT 1
- Add source and target endpoint as label for all client/server grpc metrics HOT 2
- Support ignore logging for v2(already attached PR) HOT 3
- Prometheus metrics label value inconsistency between Go and Java HOT 3
- [logging] disable option does not work with request/response fields HOT 6
- go-grpc-middleware/providers/openmetrics/v2 v2.0.0-rc.3 dependency of go-grpc-middleware/v2 v2.0.1 broken HOT 8
- Q: Logger migration HOT 2
- Support extensibility of retry condition
- [feat]: logging should loging grpc request msg HOT 1
- Example will log only first field HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-grpc-middleware.