GithubHelp home page GithubHelp logo

Comments (6)

mwitkow avatar mwitkow commented on May 5, 2024

Glad you're finding the payloads logger useful :)

The idea here was that the Entry you pass into the Payload logger already contains the level you want to log as.

Would that be enough?

from go-grpc-middleware.

coderjz avatar coderjz commented on May 5, 2024

We're using both the validation and logging packages and they're quite useful, thank you! :)

Note that I first did the change by using the log level of the entry and the tests were throwing panics. Looking into it, it seems that logrus only sets the log level of the entry when you log at least once, and the entry defaults to loglevel.Panic (link1, link2).

Because of the panics, I instead use the entry's logger level.

To test logrus default levels:

	fmt.Println(logrus.NewEntry(logrus.StandardLogger()).Level)  //Prints panic
	fmt.Println(logrus.NewEntry(logrus.StandardLogger()).Logger.Level)  // Prints info

from go-grpc-middleware.

coderjz avatar coderjz commented on May 5, 2024

Just a question though, the logger's level usually refers to the minimum level that we allow to print logs, whereas the payload logger level is the level we are printing the logs. Could this cause some conceptual confusion to users of the package?

from go-grpc-middleware.

mwitkow avatar mwitkow commented on May 5, 2024

I'm just wondering whether this could be solved with one solution like #89, and make that extend to the payload logging.

from go-grpc-middleware.

coderjz avatar coderjz commented on May 5, 2024

I suspect that we may want to use a PayloadOptions type (feel it would be poor to overload the Options to include modifications to the Payload interceptors) -- let me know if you agree.

Solution #89 is interesting but in our case we just want a default log level, similar to what is provided by grpc_logrus.WithLevels.

I won't have time in the near future to do a PR, but if we agree on the approach I should be able to get to it eventually.

from go-grpc-middleware.

bwplotka avatar bwplotka commented on May 5, 2024

This is pretty old and we know have v2 code with different structure. Let us know if this is still important, we can reopen.

from go-grpc-middleware.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.