GithubHelp home page GithubHelp logo

Comments (9)

ctalkington avatar ctalkington commented on August 14, 2024

yes its mainly to do with fact that dots can be part of folder names on some OS and theres no quick solid way to handle multiple dots as filename. auto basePath isn't perfect and was designed to make life easier atleast most the time.

can you run with --verbose and tell me what basePath is being used and atleast a sample config.

from grunt-contrib-compress.

stratoukos avatar stratoukos commented on August 14, 2024

here is the relevant part of the gruntfile.

Since I'm not specifying basePath it defaults to false and is then converted to '.' in compress.js:117. Then, in line 128, grunt.util._(relative).strRight(basePath) strips the leading ..

I would provide the output of grunt -v, but it exposes much more information about my project than I'm comfortable with. I hope this isn't a problem.

from grunt-contrib-compress.

ctalkington avatar ctalkington commented on August 14, 2024

@stratoukos thanks, ill see if i can build a test with dotfiles and figure out where its getting the . from in basePath cause with presentation it shouldnt find any common parts.

from grunt-contrib-compress.

ctalkington avatar ctalkington commented on August 14, 2024

also just to note, if you use newer versions of grunt-contrib-compress, the mode option is automatic by extname.

from grunt-contrib-compress.

ctalkington avatar ctalkington commented on August 14, 2024

i think I see the issue. it looks like in your case, dirname is returning a . for the presentation.html file. this plus your dotfiles makes . be the basePath.

from grunt-contrib-compress.

ctalkington avatar ctalkington commented on August 14, 2024

for now, if you want to work around this, you could move everything up a level or pass any string (maybe / since its trimmed anyways). im going to see about improving the basePath in the next week.

from grunt-contrib-compress.

ctalkington avatar ctalkington commented on August 14, 2024

ok so gruntjs/grunt-lib-contrib@9f93104 should address this. should be pushed by next week.

from grunt-contrib-compress.

stratoukos avatar stratoukos commented on August 14, 2024

Thanks for looking into this. I'm working around this by passing a random string as the basePath.

from grunt-contrib-compress.

ctalkington avatar ctalkington commented on August 14, 2024

this should be resolved with newer lib-contrib, atleast as much as we can without breaking other methods. hope it helps!

from grunt-contrib-compress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.