Notebooks expect labels rather than widgets. about gtk

[gkoz]

It looks like we'll be taking random types of widgets a lot. It might be worth pondering whether static or dynamic dispatch is preferable here.

[gkoz]

The position arguments seem to call for a type that would let us specify either a specific number, or 'end'. Option could work for that but would be less explicit. Do any other parts of gtk use the same convention?

[StephanvanSchaik]

At the moment, I would propose the following patch to fix the issue with the widget types (I'll send a pull request later).

Well, there are similar cases of insert functions, such as this one.

[gkoz]

The input position parameters will need a separate PR then to decide on the type to use.
I'll make a PR to add a conversion for Option<u32> so we can at least give the output values the time_t treatment.
You can avoid a little bit of gtk:: repetitiveness by importing the WidgetTrait.

[gkoz]

gtk-rs/glib#5 should help reduce boilerplate in cases where negative values represents failure.

[GuillaumeGomez]

With the PR merged, I guess this issue can be closed ?

[StephanvanSchaik]

Yes, this issue has been resolved :).