Comments (17)
Interesting. Will look at this when I have a minute.
from gulp-coffee.
Additionally, when you use { bare: true }
, the coffee-script compiler doesn't declare top-scope variables anymore... and strips all the empty lines.
from gulp-coffee.
After some tests, the bug seems happening when giving multiple files by glob.
gulp.src( [ "src/**/*.litcoffee" ] )
.pipe( coffee( options ) )
.on( "error", gutil.log )
.pipe gulp.dest "bin"
-> generates bugs and undeclared variables
gulp.src( [ "src/models/dicecheck.litcoffee" ] )
.pipe( coffee( options ) )
.on( "error", gutil.log )
.pipe gulp.dest "bin"
-> generate proper compiled file
I have absolutely no idea how to debug this (I still haven't much experience with gulp), but this is really anoying... :(
from gulp-coffee.
I've found it !
When you send multiple files, the options
seems to be populated with properties which confuse the coffeescript compiler.
I will make a pull request this afternoon.
from gulp-coffee.
Which options?
Also, does the litcoffee stuff work fine without telling the coffee compiler specifically that it is litcoffee?
from gulp-coffee.
Hmm maybe we should infer that from the file extension instead of explicity passing in literate: true
- thoughts?
from gulp-coffee.
When you don't give literate: true
, compilation fails on some files :/
from gulp-coffee.
I can confirm this bug for config { bare: true }
.
Using the class example in http://coffeescript.org/#classes
The compiled js gets borked: https://github.com/Dashed/gulp-coffee-sandbox/blob/master/src/subdir/a.js
The global vars seems to be missing.
from gulp-coffee.
I'm currently writing a fix, I will make the pull request soon.
from gulp-coffee.
Et voilà ! 290f1fc
from gulp-coffee.
Fantastic, I just tested your PR on my sandbox. Works perfectly.
from gulp-coffee.
You're welcome.
I hope it will be merged & published on npm soon, to fix the issues in my work-project builds... :)
from gulp-coffee.
@leny You may want to add more default options into your PR as listed here: https://github.com/gruntjs/grunt-contrib-coffee/blob/master/tasks/coffee.js#L17
from gulp-coffee.
@dashed done. Thanks.
from gulp-coffee.
from gulp-coffee.
@Jenius it's patched in 1.2.5 and is available on npm. =] if it works as your side, and there are no outstanding problems, then please close this ticket
from gulp-coffee.
Looks good - thanks guys!
from gulp-coffee.
Related Issues (20)
- Let's bump new version! HOT 5
- Converts variables with @$ to _at_$ HOT 6
- What's the canonical way to do partial rebuilds? HOT 1
- Error handler being ignored HOT 3
- Support the --join option HOT 5
- Formatting errors with gulp-util HOT 8
- How can I include file ? HOT 1
- why does gulp-coffee uglify the compiled *.js file under 'build/' using gulp-coffee HOT 2
- Latest version of Coffeescript HOT 2
- gulp-coffee won't compile after an error occured(and handled) when used with gulp-watch HOT 4
- do sourcemaps still work? HOT 3
- Update coffee-script dependency HOT 2
- Cofeescript2 support? HOT 5
- Update Node versions tested in CI
- Remove lock files HOT 2
- Update repo location HOT 1
- coffeescript 2 with transpile + inlined source maps? HOT 9
- How not to strip empty lines? HOT 2
- remove gulp-util using the following API replacements HOT 1
- Needs new release to remove merge vulnerability HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gulp-coffee.