GithubHelp home page GithubHelp logo

Comments (17)

yocontra avatar yocontra commented on July 17, 2024

Interesting. Will look at this when I have a minute.

from gulp-coffee.

leny avatar leny commented on July 17, 2024

Additionally, when you use { bare: true }, the coffee-script compiler doesn't declare top-scope variables anymore... and strips all the empty lines.

from gulp-coffee.

leny avatar leny commented on July 17, 2024

After some tests, the bug seems happening when giving multiple files by glob.

gulp.src( [ "src/**/*.litcoffee" ] )
        .pipe( coffee( options ) )
            .on( "error", gutil.log )
        .pipe gulp.dest "bin"

-> generates bugs and undeclared variables

gulp.src( [ "src/models/dicecheck.litcoffee" ] )
        .pipe( coffee( options ) )
            .on( "error", gutil.log )
        .pipe gulp.dest "bin"

-> generate proper compiled file


I have absolutely no idea how to debug this (I still haven't much experience with gulp), but this is really anoying... :(

from gulp-coffee.

leny avatar leny commented on July 17, 2024

I've found it !

When you send multiple files, the optionsseems to be populated with properties which confuse the coffeescript compiler.

I will make a pull request this afternoon.

from gulp-coffee.

yocontra avatar yocontra commented on July 17, 2024

Which options?

Also, does the litcoffee stuff work fine without telling the coffee compiler specifically that it is litcoffee?

from gulp-coffee.

yocontra avatar yocontra commented on July 17, 2024

Hmm maybe we should infer that from the file extension instead of explicity passing in literate: true - thoughts?

from gulp-coffee.

leny avatar leny commented on July 17, 2024

When you don't give literate: true, compilation fails on some files :/

from gulp-coffee.

dashed avatar dashed commented on July 17, 2024

I can confirm this bug for config { bare: true }.

Using the class example in http://coffeescript.org/#classes

The compiled js gets borked: https://github.com/Dashed/gulp-coffee-sandbox/blob/master/src/subdir/a.js

The global vars seems to be missing.

from gulp-coffee.

leny avatar leny commented on July 17, 2024

I'm currently writing a fix, I will make the pull request soon.

from gulp-coffee.

leny avatar leny commented on July 17, 2024

Et voilà ! 290f1fc

from gulp-coffee.

dashed avatar dashed commented on July 17, 2024

Fantastic, I just tested your PR on my sandbox. Works perfectly.

from gulp-coffee.

leny avatar leny commented on July 17, 2024

You're welcome.

I hope it will be merged & published on npm soon, to fix the issues in my work-project builds... :)

from gulp-coffee.

dashed avatar dashed commented on July 17, 2024

@leny You may want to add more default options into your PR as listed here: https://github.com/gruntjs/grunt-contrib-coffee/blob/master/tasks/coffee.js#L17

from gulp-coffee.

leny avatar leny commented on July 17, 2024

@dashed done. Thanks.

from gulp-coffee.

jescalan avatar jescalan commented on July 17, 2024

👍 great work guys!

from gulp-coffee.

dashed avatar dashed commented on July 17, 2024

@Jenius it's patched in 1.2.5 and is available on npm. =] if it works as your side, and there are no outstanding problems, then please close this ticket

from gulp-coffee.

jescalan avatar jescalan commented on July 17, 2024

Looks good - thanks guys!

from gulp-coffee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.