PluginError: setting showStack to false not working about gulp-util

[yocontra]

What version of gulp-util is jshint and jscs using? If they update to the latest the bug has been fixed

[iamstarkov]

version bump helped, thank you

[iamstarkov]

By the way, is it normal to have such strings in output?

# in gulp-jscs
events.js:72
        throw er; // Unhandled 'error' event

# in gulp-jshint
/Users/vstarkov/projects/webapp-base/node_modules/gulp-jshint/node_modules/map-stream/index.js:103
        throw err
              ^
Error: JSHint failed for: linting.js

[yocontra]

@matmuchrapna If the stack was garbage and jshint didn't provide a better stack (or showStack: false) then it is normal

[iamstarkov]

@contra but gulp-jscs and gulp-jshit set showStack to false, so it is not normal and a bug?

[yocontra]

@matmuchrapna And both are on the newest gulp-util? Can you npm ls gulp-util?

[iamstarkov]

@contra Yes, gulp-jscs is already on [email protected] and gulp-jshint is on [email protected] after my PR also this is my npm ls gulp-util output:

webapp-base(gulp-util-bug-demo)$ npm ls gulp-util
[email protected] /Users/vstarkov/projects/webapp-base
├─┬ [email protected]
│ └── [email protected]
├─┬ [email protected]
│ └── [email protected]
└─┬ [email protected]
  ├─┬ [email protected]
  │ └── [email protected]
  └── [email protected]

Also you can clone my webapp-base repo to reproduce the problem.

[yocontra]

@matmuchrapna Can you try updating once more? gulp 3.8.7 has the new gulp-util now

[iamstarkov]

@contra it helps a little, but this strange error with (when gulp-jshint or gulp-jscs failed on error) still showing in the terminal:

events.js:72
        throw er; // Unhandled 'error' event

For reproduce use linting-test branch of my webapp-base repo.

I tried to find the problem by myself but failed with it, only one I have discovered that this.emit('error', …) cause this bug, but I cannot find event handler for this event or file events.js in my node_modules folders. Where should I continue my investigation?

[yocontra]

@matmuchrapna You have to return a stream - https://github.com/matmuchrapna/webapp-base/blob/linting-test/tasks/linting.js#L30

Use the merge-stream module to combine both into one stream, then return that.

[iamstarkov]

Thank you

[iamstarkov]

is it normal that emitted error logged on this line events.js:L72?

[yocontra]

@matmuchrapna That's just how stacktraces work in JS - when you emit an error the emitter itself is in the stack now

[iamstarkov]

@contra thank you for answer