GithubHelp home page GithubHelp logo

Comments (2)

chambaz avatar chambaz commented on August 18, 2024

Hi,

Thanks for pointing this out. They appear to be working for me but are throwing me up to the top of the window. If you scroll back down you can see they did in fact work.

It appears the e.preventDefault() call that prevents the anchor from linking to href="#" on desktop is not functioning correctly on iOS.

I'm looking into this issue now, I'll keep you posted.

from gumby.

chambaz avatar chambaz commented on August 18, 2024

The issue was with click events firing when the gumbyTap event is set up. On mobile devices the preventDefault() call only prevents the gumbyTap event default.

I have added a click event handler to elements using gumbyTap where I can use stopImmediatePropagation(); which prevents the anchor from linking to href="#".

I've pushed the fix to the website and this repo. Thank you for pointing the issue out!

from gumby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.