GithubHelp home page GithubHelp logo

Comments (3)

chambaz avatar chambaz commented on August 18, 2024

Hey,

I see the issue here, it occurs when there's no logo in your nav bar. When the mobile styles are applied the <ul> is hidden and the visible logo retains the navbar height. However, when the logo is removed there is effectively no content inside the navbar which is why it loses it's background color. The 1px line appears to come from the hidden <ul> which is actually rendered at 1px height for some reason. We need min-heights to ensure the navbar doesn't collapse when the logo is removed.

We are looking into this issue, I'll keep you posted. Or please feel free to submit a pull request if you find a fix.

from gumby.

craigkeller avatar craigkeller commented on August 18, 2024

@heyneff Thanks for reporting this! It seems that the issue was with column classes within the nav inheriting the min-height property from their global counterparts. I added .navbar .column, .navbar .columns {min-height: 0;} which kicks in at the all-phones breakpoint to the scss. thanks again! Hope this works for you!

from gumby.

heyneff avatar heyneff commented on August 18, 2024

@chambaz @craigkeller Thanks guys, both for the explanation and the quick fix. That did the trick!

from gumby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.