GithubHelp home page GithubHelp logo

Comments (8)

pobonomo avatar pobonomo commented on June 13, 2024

Ideally there would be a pre-commit hook to do It.

from gurobi-machinelearning.

twbraam avatar twbraam commented on June 13, 2024

Which files exactly?
Do you have an example file where we have the copyright and license statements setup the way you want it?

from gurobi-machinelearning.

pobonomo avatar pobonomo commented on June 13, 2024

I think that all python source file should have it.
For notebooks maybe it can be put in the metadata.

I am not sure yet what to put. I saw various shorter or longer versions.

from gurobi-machinelearning.

pobonomo avatar pobonomo commented on June 13, 2024

I think that this should be the shorter version:

https://github.com/Gurobi/gurobi-machinelearning/blob/c5c9e539769e8bfabdb47ee249ea6ddc9adc6a57/copyright.txt

Yesterday I tried various pre-commit hooks that claim to check copyright notice but they didn't seem to work.

from gurobi-machinelearning.

twbraam avatar twbraam commented on June 13, 2024

I've added the hook. Now we just need to touch all the existing files that don't adhere to this check yet.

Can you a quick check, also the regex in .pre-commit-config.yaml for which files to check?

from gurobi-machinelearning.

pobonomo avatar pobonomo commented on June 13, 2024

Thanks! I think I fixed all the files. The pre-commit setup is good.

(only issue now is the static version of the webpage but this should be really removed I guess).

That's some really bad ass copyright notice 😆

from gurobi-machinelearning.

pobonomo avatar pobonomo commented on June 13, 2024

Oh it missed some files...

from gurobi-machinelearning.

twbraam avatar twbraam commented on June 13, 2024

Thanks for fixing it. Was not sure how pre-commit works. But we seem to have a handle on it now.

from gurobi-machinelearning.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.