GithubHelp home page GithubHelp logo

Comments (3)

guyzmo avatar guyzmo commented on June 15, 2024

uh.. looks like pip 10 did a major API change. As I've heard, pip integrated a bunch of hacks that was necessary into the project, and changed a bunch of its internals. So I need to check the new better way of doing things and update this :)

I'm open to suggestions/pointers to help me expedite this, as I'm being currently snowed with paying work :)

from git-repo.

nikitavbv avatar nikitavbv commented on June 15, 2024

I'm open to suggestions/pointers to help me expedite this, as I'm being currently snowed with paying work :)

Generally, it is not a good practice to read requirements.txt from setup.py and install_requires should be listed in setup.py separately from requirements.txt. There is a really good explanation for this on StackOverflow.

There are three possible solutions:

  1. List requirements in setup.py separately from requirements.txt in a proper way.
  2. Just change current code a bit to adapt to pip changes: they have moved req to _internal, so something like from pip._internal import req should work. But that is a hack, not a good solution :)
  3. Just read requirements.txt as file and use its lines for install_requires. Some repos followed this way: example.

I would be happy to help to solve this issue (incl. pull request).

What are your thoughts on this?

from git-repo.

nikitavbv avatar nikitavbv commented on June 15, 2024

I pushed PR #191, which fixes this issue

from git-repo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.