Comments (2)
Hi @shinenelson - Thanks for the detailed report!
I actually intended this action to be used in conjunction with a push
event as well on the main branch so that the coverage is tracked for commits on that branch
The problem with relying on notes attached to commits in the PR is that they're essentially lost when/if the branch is rebased or squash-merged as the hash will change.
from go-coverage-action.
The problem with relying on notes attached to commits in the PR is that they're essentially lost when/if the branch is rebased or squash-merged as the hash will change.
Fair enough. It would be helpful to add this to the ReadMe so that another user who attempts to run this action only on: pull_request
event would not be confused by this " intended behaviour "
from go-coverage-action.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-coverage-action.