GithubHelp home page GithubHelp logo

maven artifact release? about sqlite-dialect HOT 26 CLOSED

gwenn avatar gwenn commented on August 14, 2024
maven artifact release?

from sqlite-dialect.

Comments (26)

vladmihalcea avatar vladmihalcea commented on August 14, 2024 4

@devinant I reasked the question on the mailing list. This integration must be approved because it must be agreed that the Dialect will be maintained in future as well. I'll come back when I have more details for this.

from sqlite-dialect.

gwenn avatar gwenn commented on August 14, 2024 3

from sqlite-dialect.

richfell-org avatar richfell-org commented on August 14, 2024 3

Just to note, I used the JitPack method and it does work.

from sqlite-dialect.

gwenn avatar gwenn commented on August 14, 2024 2

@kwilliams3, the first link works for me!
Thanks to the generous soul who released it.

from sqlite-dialect.

Region40 avatar Region40 commented on August 14, 2024 1

It looks like there's another option here, and the GitHub repo which it comes from is located here. It looks like you made commits to it, @gwenn , and it also seems that he didn't really change anything. Do you approve of this maven artifact as a solution to this issue? It doesn't have any of your commits since 2015. Maybe a future collaboration with Kemitix could resolve that.

from sqlite-dialect.

gwenn avatar gwenn commented on August 14, 2024 1

https://repo1.maven.org/maven2/com/github/gwenn/sqlite-dialect/0.1.0/

from sqlite-dialect.

gwenn avatar gwenn commented on August 14, 2024

First, I don't know if the groupId/package org.hibernate.dialect can be used freely ?
Second, I don't know how to publish an artefact to the maven central repository (I will check the guide).

from sqlite-dialect.

gwenn avatar gwenn commented on August 14, 2024

I've asked for help here.

from sqlite-dialect.

berdario avatar berdario commented on August 14, 2024

This is the only thing that appears there:

The requested topic does not exist.

from sqlite-dialect.

vladmihalcea avatar vladmihalcea commented on August 14, 2024

The Hibernate posts are moderated the first time you post a question, that's why you didn't see. Now, it's available.

from sqlite-dialect.

fernandojunior avatar fernandojunior commented on August 14, 2024

Nice. You forgot to include the dialect in DialectFactoryTest.java

from sqlite-dialect.

gwenn avatar gwenn commented on August 14, 2024

Many thanks.
I am going to fix it...

from sqlite-dialect.

vladmihalcea avatar vladmihalcea commented on August 14, 2024

Thanks for the Hibernate PR. I'll review it tomorrow.

from sqlite-dialect.

devinant avatar devinant commented on August 14, 2024

@vladmihalcea any news on this?

from sqlite-dialect.

ph4r05 avatar ph4r05 commented on August 14, 2024

Hi,

I've just modified the dialect to work with Hibernate 4.3.11.Final.
https://github.com/EnigmaBridge/hibernate4-sqlite-dialect

I've also added it to the central maven repository.

I can do the same with this one for Hibernate 5 - if owner approves it, or I can help with the uploading to the central repository. Let me know if interested.

from sqlite-dialect.

gwenn avatar gwenn commented on August 14, 2024

I am sorry but I don't understand: your repository is not a clone !
And I would prefer not have to publish on maven central repository.

from sqlite-dialect.

ph4r05 avatar ph4r05 commented on August 14, 2024

To clear that up. I modified the code so it works for Hibernate 4.3.11.Final and I published it to the maven central repository.

I was asking if you want me to publish variant for Hibernate 5 to maven central repository OR if you want me to help you with publishing it.

I noticed you are working with Hibernate team with integrating dialect directly to the Hibernate (which is great!), but it is 3.5 months and it is still not there. So I was wondering we can add SQLite dialect for Hibernate 5 also to maven central repository so others can simply use it.

from sqlite-dialect.

gwenn avatar gwenn commented on August 14, 2024

Don't take me wrong but:

  • It seems to me that you can't change the licence:

https://github.com/EnigmaBridge/hibernate4-sqlite-dialect/blob/master/pom.xml#L15

    <licenses>
        <license>
            <name>Apache License, Version 2.0</name>
            <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
            <distribution>repo</distribution>
        </license>
    </licenses>

Versus
https://github.com/gwenn/sqlite-dialect/blob/master/pom.xml#L13

  <licenses>
    <license>
      <name>Public domain</name>
      <url>http://unlicense.org/</url>
      <distribution>manual</distribution>
    </license>
  </licenses>
  • And I don't know if the org.hibernate.dialect package can be use freely.
  • And maybe we should ask D. Richard Hipp if we can use the SQLite name.

Regards.

from sqlite-dialect.

gwenn avatar gwenn commented on August 14, 2024

And it seems there is one difference/bug:
https://github.com/EnigmaBridge/hibernate4-sqlite-dialect/blob/master/src/main/java/org/hibernate/dialect/SQLiteDialect.java#L157

        @Override
        public boolean bindLimitParametersInReverseOrder() {
            return false;
        }

from sqlite-dialect.

ph4r05 avatar ph4r05 commented on August 14, 2024
  • Regarding the license - you are right about the change. You put it to the public domain. I am not aware of any issue why I couldn't re-license it under something different: Unlicensed works, modifications, and larger works may be distributed under different terms and without source code[1]. I changed the license to the most open one - MIT. I generally prefer MIT over public domain licenses as it has more clear meaning from the perspective of the law [1, 2]. It is the most compatible and permissive license I know. I hope it is OK for you now.
  • The package name - it is already used in net.kemitix If somebody has problem with the package name I can change it as well. I asked @vladmihalcea on Twitter. In case of trouble I change the package to com.enigmabridge.
  • The difference - yep, you are right, thanks. It is fixed by now.
  • Your current version - if you don't want to add it to Maven central so be it ;)
    Legally anybody can take the code and release it to the repository. But I have feeling you have some issues with this (correct me if I am wrong). I am not in a mood fighting somebody about this.

from sqlite-dialect.

ph4r05 avatar ph4r05 commented on August 14, 2024

Update:

  • After discussion with @vladmihalcea the package name was changed to com.enigmabridge.hibernate.dialect.SQLiteDialect
  • @gwenn feel free to submit PR if you want to change something
  • Maven repo - the only one I found in maven central was net.kemitix. It worked only for Hibernate v3, so I decided to update it so it works also with Hibernate v4 and put it to maven central. That was my motivation - people want to have an easy way to add SQLite dialect to the project, maven central is the way (this whole issue is about it). No file copying. I had this problem so I wanted to fix it also for others. I started with decompiling net.kemitix dialect and modifying that one, without noticing you have the repo. Thats the reason I haven't forked your repo but started a new one.

from sqlite-dialect.

gwenn avatar gwenn commented on August 14, 2024

Ok,
Thanks.

from sqlite-dialect.

CatPlanet avatar CatPlanet commented on August 14, 2024

So, can we have it in central? Is this thread still alive?

from sqlite-dialect.

gwenn avatar gwenn commented on August 14, 2024

It seems to me that you can use JitPack (not tested).

from sqlite-dialect.

Region40 avatar Region40 commented on August 14, 2024

It seems that there's a maven central repo for your dialect here. Are you aware of this, @gwenn , and is it something you've had a hand in? Apparently you can't download the jar file because it's from a university, but I don't know if that stops you from using the repo with gradle/maven.

from sqlite-dialect.

Region40 avatar Region40 commented on August 14, 2024

So, I tried using that maven repo and gradle gave me a "Could not resolve" error =/

from sqlite-dialect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.