Comments (2)
Hi, and thanks for the report!
If the problem was just I should drop the result of find_name() before making another call, that would be fine with me provided it were documented/enforced.
We can and should indeed better document it!
The result from find_name
"locks" the view you found, and prevents finding child views while this lock is kept.
(Why do we lock the view? So we can implement DerefMut
, which lets users directly call methods on the result.)
This is why it's usually preferred to use call_on_name
(it's harder to mix up locks this way).
I'm not sure we could enforce it though: it's valid to use find_name
on disjoint views, it's only an issue when one is nested another the other one.
from cursive.
Thanks for getting back to me.
I'm not sure we could enforce it though: it's valid to use find_name on disjoint views, it's only an issue when one is nested another the other one.
I was imagining find_name
would return some kind of guard which would mark the view as "locked". Then whenever find_name
is called it would search from child to root checking to make sure everything is "unlocked", panicing if not. Once the guard is dropped the lock would be released.
Having said that, I hadn't considered call_on_name
and TBH wasn't really sure why this would be used until now. Does call_on_name
have the same issue if it's re-called in a nested context? If not it sounds like this is also valid way to enforce things and perhaps the find_name
doc can just recommend call_on_name
.
Either way some mention in the docs would be most helpful.
from cursive.
Related Issues (20)
- [BUG] ScrollView not scrolling down HOT 1
- [BUG] GitHub dependabot warnings from cursive-core dependencies HOT 1
- FromFront and FromBack should equal if the position of the layer is logically same if we count from back or from the front of the stack HOT 6
- [BUG] menubar example background doesn't refresh if not focussed HOT 1
- [BUG] TextView performance regression with LinearLayout HOT 1
- [BUG] Italic Effect with ncurses-backend HOT 2
- [BUG] Panic when resizing the Terminal too small HOT 1
- [BUG] Nerdfont is not being properly rendered HOT 2
- [FEATURE] Support for transparent Palette color HOT 2
- [FEATURE] Allow customization of keybindings HOT 2
- [Possible bug] Builder example isn't working HOT 3
- [BUG] Building Cursive with `--features ansi` yields a future incompatibility warning due to nom v4.2.3 HOT 4
- [FEATURE] How would I bring form, panel, and menu into this? HOT 1
- Documentation issue about textarea set_cursor HOT 2
- [BUG] While using cursive, stacktrace (on panic) are never printed to (non-alternate) screen HOT 2
- [FEATURE] more keys in `event::Keys` HOT 2
- [BUG] Shift+Up/Down do not work w/ Termion backend HOT 2
- [BUG] cursive.clear() does not work. HOT 2
- [FEATURE] `CheckBox` as multichoice with similarity to `RadioGroup` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cursive.