Comments (3)
- fix card editing x overflow
from skola.
Hey 👋 I was looking at this ... it seems that the menu is a bit broken at the moment ...
like there are pages where you can't escape (the unimplemented ones ofc)
and pages you can only go back from (all the others)
the best would probably be to have the hamburger menu on all pages instead of the "<" or nothing...
i was wondering if you agree, and if we should go with something like a top bar like this https://mantine.dev/app-shell/?e=BasicAppShell with some generic name or custom per page...
or you prefer we put the menu on every page or something?
from skola.
I agree with you that the navigation on mobile could be improved especially with the non-implemented dead end routes.
The navbar is actually implemented but on mobile only accessible from the home view via the hamburger item.
I actually had a (generic) header bar implemented with a universally accessible hamburger menu too (still visible in the screenshot in the readme). I removed it because I felt like it took up too much screen real estate.
(For example, in the deck view the "<", title and three-dotted options menu already take up quite a bit of y space. Adding another header bar on top would move everything else down. In that case you might have to scroll down to access things like the sub decks on smaller screens.)
What I am trying to say is that a header bar would need to be useful enough to always be present. So probably it shouldn't be generic; more than just a hamburger menu.
I think a header bar component with custom content for each page could make sense...
from skola.
Related Issues (20)
- Improving the add cards experience HOT 2
- Move all the dropdowns at the top into the header bar if possible to free up space. Figure out how to place these on mobile
- Edit mode doesn't check for new cloze cards
- Delete shared value if last reference to it is deleted
- Ability to export and import entire database
- Image occlusion cards
- Rewrite of card leaning / scheduling and migration to FSRS HOT 2
- Show all cards that link to shared value
- Better keyboard support HOT 2
- Populate Today Section
- Header Bar on mobile HOT 10
- Adding/removing cloze after creating the card doesn't work HOT 3
- Sound Card HOT 2
- Move subdecks HOT 8
- No way to add subdecks in Sidebar HOT 2
- Menu in Notebook view HOT 4
- Cloze card preview HOT 3
- "Duplicate" cards HOT 3
- Fonts sometimes don't load correctly HOT 8
- React Router: Should have a queue. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skola.