Comments (5)
You're absolutely correct that the debounce is making an otherwise synchronous validation async so it immediately returns true
. We should fix that.
It's worth mentioning here that returning the cached value is what happens "by design" if there's a remote or other Promise-returning validator involved. Ideally the method would return a Promise<bool>
, but that's a breaking change. Maybe v2?
That might still make the return value unreliable if debounce is not 0 though.
This is also correct, and we should fix that.
validateField()
should always call the underlying validator, undebounced.- Only the
change
/input
handler should be debounced.
I actually have a branch in progress (for #100) that's adjusting how the callback is wired/unwired, so I can include this fix in that change.
from aspnet-client-validation.
Well, thank you very much. Sorry to pile stuff on to your plate.
from aspnet-client-validation.
Give this a try? #110
from aspnet-client-validation.
Not sure if Phil has made his changes from review. Let me know when the review is good to test.
from aspnet-client-validation.
I fixed the bug Phil found. 👍 Please test!
from aspnet-client-validation.
Related Issues (20)
- Add CDN to documentation HOT 4
- checkbox validation does not work HOT 3
- isFieldValid not working as expected if prevalidate is false HOT 10
- Calling `validateForm` submits the form in Firefox
- razor pageremote type=post HOT 1
- [Q] Reparse form without using `watch:true` MutationObserver HOT 2
- [Bug] Checkbox validation does not work (verified in demo app) HOT 2
- Should not validate disabled fields HOT 9
- Option to ignore particular fields HOT 1
- Do not validate immediately HOT 4
- Purpose of debounce HOT 1
- Disabling validation HOT 6
- How to use with Razor Pages, i.e. using PageRemote attribute and not Remote attribute? HOT 1
- Latest bits are not in dist folder nor jsdelivr HOT 2
- The isValid method throws if the form does not contain any validation attributes HOT 3
- Custom validator for "differs to" HOT 5
- Rescanning dynamic inputs does not detect that they are new HOT 3
- Required validator differs from MVC validation in allowing bypass by using spaces in value. HOT 7
- Docs for remove validation feature
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aspnet-client-validation.