GithubHelp home page GithubHelp logo

Comments (5)

dahlbyk avatar dahlbyk commented on May 19, 2024

You're absolutely correct that the debounce is making an otherwise synchronous validation async so it immediately returns true. We should fix that.

It's worth mentioning here that returning the cached value is what happens "by design" if there's a remote or other Promise-returning validator involved. Ideally the method would return a Promise<bool>, but that's a breaking change. Maybe v2?

That might still make the return value unreliable if debounce is not 0 though.

This is also correct, and we should fix that.

  1. validateField() should always call the underlying validator, undebounced.
  2. Only the change/input handler should be debounced.

I actually have a branch in progress (for #100) that's adjusting how the callback is wired/unwired, so I can include this fix in that change.

from aspnet-client-validation.

RyanONeill1970 avatar RyanONeill1970 commented on May 19, 2024

Well, thank you very much. Sorry to pile stuff on to your plate.

from aspnet-client-validation.

dahlbyk avatar dahlbyk commented on May 19, 2024

Give this a try? #110

from aspnet-client-validation.

RyanONeill1970 avatar RyanONeill1970 commented on May 19, 2024

Not sure if Phil has made his changes from review. Let me know when the review is good to test.

from aspnet-client-validation.

dahlbyk avatar dahlbyk commented on May 19, 2024

I fixed the bug Phil found. 👍 Please test!

from aspnet-client-validation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.