IE10 freeze about react-datepicker

[seanconnollydev]

I ran into this with IE 9 and 10 as well. It looks like it was introduced with v0.11 (I was not able to reproduce with v0.10). I verified that this was not caused by my pull request #135. I would appreciate a fix ASAP, I've been waiting on v0.11.

[RSO]

I will check it out, however, as of yet I have no way to test in IE, I'll have to look into that as well.

[RSO]

I'll have to download an IE11 vm for my mac, so that'll take some time. If somebody else could provide me with a trace/screenshot/whatever it would mean a lot to me!

[seanconnollydev]

There are no errors being console logged as far as I can see. I am attaching a screenshot, the steps to reproduce are:

1. Open IE
2. Go to http://cdn.rawgit.com/Hacker0x01/react-datepicker/master/example/index.html
3. Click the first input field
4. Select a date
5. IE locks up, must be shut down

[RSO]

Fixed in dad57db. @martijnrusschen will do a release. Thanks for reporting!

[RSO]

Now I'll have to figure out how to run tests in sauce-labs, and write a test for this in IE!

[martijnrusschen]

Version 0.11.2 has been released!

[seanconnollydev]

Thanks for the quick turn around guys.
On Jul 29, 2015 4:16 AM, "Martijn Russchen" [email protected]
wrote:

Version 0.11.2 has been released!

—
Reply to this email directly or view it on GitHub
#141 (comment)
.

[seanconnollydev]

I am unfortunately still seeing this issue in IE10. IE9 seems to be working. I was able to reproduce after upgrading locally and on the examples page.

[martijnrusschen]

Debugging here #150, would be cool if we could reproduce these issues in a test.

[seanconnollydev]

It looks like this is still not working in IE10 as of 0.11.3. I unfortunately will not be able to debug until sometime next week but I would really appreciate a fix.

[truckingsim]

This freezes in IE11 and IE10 in 0.11.4. We've been attempting to debug it to figure out why but haven't gotten anywhere with it yet.

[seanconnollydev]

It looks like IE is handling the input's onChange event in an unexpected way, which is causing an infinite loop when you select a value from the calendar. I made a modification that will fix this. I am not sure if it is the best fix. I cannot initiate a pull request though because I needed to add a hack to our version to fix another IE issue, which is preventing the calendar from closing when you press enter.

See changes made to fix the IE freeze issue:
master...ShipCompliant:66389ec2811168b22bf1d14ba4e2f48fa73393ca

[martijnrusschen]

Thanks for looking into this, I'll see if I can create a PR based on your changes. Would be happy to get this fixed though!

[dcousineau]

@martijnrusschen @sconno05 try my PR above and let me know if that works for you both (it's working for us)

[martijnrusschen]

@sconno05 Can you confirm, that PR fixed your issues too? I'm happy to merge it if it fixes the IE issues. Thanks @dcousineau!

[dcousineau]

No problem!

[seanconnollydev]

I pointed our app to https://github.com/croscon/react-datepicker.git, but
the infinite loop was still occurring in IE10.

On Thu, Aug 13, 2015 at 4:33 PM, Daniel Cousineau [email protected]
wrote:

No problem!

https://camo.githubusercontent.com/cb0284baebb09a44f53cb5dc50802394998031c1/687474703a2f2f6d65646961302e67697068792e636f6d2f6d656469612f77547a5053785a4271536f76652f67697068792e676966

—
Reply to this email directly or view it on GitHub
#141 (comment)
.

[martijnrusschen]

To make sure, did you point it to the correct branch? Looking at his repo, it should be bugfix-ie-infinite-loop

[seanconnollydev]

Good call. Pointing to the correct branch, it does fix our issue.

On Thu, Aug 13, 2015 at 9:01 PM, Martijn Russchen [email protected]
wrote:

To make sure, did you point it to the correct branch? Looking at his repo,
it should be bugfix-ie-infinite-loop

—
Reply to this email directly or view it on GitHub
#141 (comment)
.

[martijnrusschen]

Cool, lets do this! Thanks for confirming the fix @sconno05

[martijnrusschen]

Released: https://github.com/Hacker0x01/react-datepicker/releases/tag/v0.11.5

[dcousineau]

[martijnrusschen]

Resolving this, lets reopen if it still occurs! Thanks guys!