Comments (12)
I think we can just do the version from 6/7 that halves user's hp, if that's all right
from femultiplayer-v2.
I think we can just do the version from 6/7 that halves user's hp, if that's all right
Miracle didn't exist in FE 6 - 8, so I guess you mean from 9 and 10 (Path of Radiance and Radiant Dawn aka the Tellius Series). Might be a fair tradeoff given the Luck % would make the activation rate pretty low, however I'm concerned that since this skill coupled with superior movement makes them currently overall better to Sages and Bishops, I think this should be balanced with either a Def buff for Sages / Bishops, or by giving Valkyries a Mag nerf as Valkyries are meant to only have average stats at best coupled with high avoid. Opinions?
from femultiplayer-v2.
mb, yeah 9-10. I think that halving rather than awakening-onwards' 1 hp would be a balanced alternative. I absolutely agree that mag should be nerfed for valkyries, or maybe disable tome use
from femultiplayer-v2.
https://github.com/eliatlarge/FEMultiPlayer-V2/blob/1.3/src/net/fe/fightStage/Miracle.java#L28
Miracle's activation rate is Luck%. What was your sample size?
from femultiplayer-v2.
Running two clients on my own computer, I pitted myself using a really angry Lv 20 Eliwood against a team of Lv 1 Valkyrie for 3 games in a row, Miracle activated without fail on all of them if all of the following conditions are met:
- The Valkyrie in question had full health
- The Valkyrie in question never participated in a battle yet that game (this may include healing other units - have yet to test that)
- The lethal blow is the 1st / only hit of that encounter
Meaning that either they have some OHKO protection clause, or a stray part of the "Divine Intervention" modifier or other test code is somehow running despite not being enabled.
from femultiplayer-v2.
From what I see in the code, Here's what determines Miracle:
return RNG.get() < user.get("Lck") && user.getHp() != 1;
which translates to:
successful if luck% and current hp is not 1.
and for damage calculation:
if(d.getHp() - damage <= 0){
return d.getHp() - 1;
} else {
return damage;
}
meaning:
if this attack is lethal,
deal damage equal to the HP - 1.
otherwise,
deal normal damage.
English is a strange programming language. I do believe that the problem is that it uses the hp from the beginnning of the round, and if the unit has already been dealt damage, it will still deal damage equal to whatever the initial hp was minus 1.
Best I can tell, you must have accidentally been running Divine Intervention. in that mode, 'Miracle' always triggers if hp is > 1, period. You might want to check on that, but I'll definitely look more into the code.
from femultiplayer-v2.
Best I can tell, you must have accidentally been running Divine Intervention. in that mode, 'Miracle' always triggers if hp is > 1, period. You might want to check on that, but I'll definitely look more into the code.
I can assure you I didn't enable any modifiers during this. It just triggers if the unit had full health, never participated in battle, and sustains a lethal hit on the first / only strike. FEMP hogging my CPU makes recording proof of this unfeasible but I'll get screenshots to show this later tonight as I can recreate this bug consistently.
from femultiplayer-v2.
First game of the night. Again, I can consistently trigger Miracle if the conditions I stated are fulfilled. I also don't have ANY modifiers running when this happens. Examine to code of both FEMP and FEServer to make sure that nothing is guaranteeing it for Valkyries.
from femultiplayer-v2.
I tried with lvl 20 Eirika vs 3 Valkyries, and only 1 of them managed to proc miracle. You might want to try a fresh version of femp; perhaps the special miracle managed to stick on, somehow. or maybe you're the unluckiest (luckiest? main valkyries in the tourney) man alive.
from femultiplayer-v2.
somehow. or maybe you're the unluckiest (luckiest? main valkyries in the tourney) man alive.
This, the Miracle streak between test armies and Sarah's teams finally came to an end late tonight after Sarah got cocky and brought multiple valkyries with her. They met their end at Sain's Halberd.
Closing as "Not A Bug / Works For Me". Meanwhile, maybe we should look at the RNG and see why it seems to roll a successful Miracle so often. Sorry for the inconvenience.
from femultiplayer-v2.
True hit?
from femultiplayer-v2.
Not sure, it was a really bad string of luck for me apparently, sorry for the late reply. I just did the test running two clients on the same computer again, with another valkyrie slaughter fest, all 3 on each team, and only one triggered Miracle.
For whatever bizarre reason, it kept triggering beforehand without modifiers. I guess we'll never know what happened.
EDIT: I think when I noticed it the most, playing against Sarah, her Valkyries were Lv20, meaning that their Luck was 30 or better, which I guess would make it a 1 in 3 chance of Miracle triggering. Probably was just bad luck for me.
from femultiplayer-v2.
Related Issues (20)
- Add a detailed character screen
- Unit's last known Field of Vision remains after being Rescued HOT 1
- Spectators should be able to see mutual fields of vision in FoW HOT 1
- Camera location updates during FoW Enemy Phase HOT 1
- Desynced ready status when returning to lobby
- app.config is undocumented HOT 3
- Improve Level Editor HOT 2
- Repositioning before the start of a game
- Add unique music option to app.config for battles involving Lords HOT 2
- Rage Mechanic
- Using Give Command crashes Server
- Server crash when smiting/shoving HOT 1
- Guy and Matthew can break the speed cap of 35
- Show previously saved teams in the "load team" dialog HOT 1
- Allow spectators to join and watch a game in progress HOT 1
- Dropped rescued enemies are shown grayed out HOT 2
- Spectators are required to be ready to start a match
- Red team's rescue icon is the wrong color
- Effective weapons aren't flashing in FightStage
- Add a game timer
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from femultiplayer-v2.