Question about max byte slice about avro

[torwig]

My apologies, gentlemen.

[nrwiersma]

No harm no foul. i could have scrutinised this more, but didn't.

[nrwiersma]

This is a bug in maxByteSliceSize. Thanks for catching this.

[hhromic]

My question is: 1024*1024 it's not equal to 1 MiB. Is there a typo in the configuration parameter or typo in the maxByteSliceSize value? Or there is somewhere multiplication by 1024 before using it?

I know this was recently fixed, but I got very curious about this statement. To my understanding, 1024*1024 is equal to 1 MiB. The PR fixing this replaced 1024*1024 with 1_048_576, but both expressions are equal.

fmt.Println(1024*1024 == 1_048_576)
// Output: true

So, I can't wrap my head around what was fixed by it 🙈.

[torwig]

@hhromic Yes, indeed equal. I understood it wrong and persuaded others.

[hhromic]

Ah, peace of mind restored! 😄.
I still liked the constant renaming, it is better now IMHO 👍.