GithubHelp home page GithubHelp logo

Comments (6)

sf105 avatar sf105 commented on July 2, 2024

you have a point. There are tradeoffs in that the typed version will catch some mistakes at compile time and works better with jmock (our original client). I'm now beginning to think that jMock should have had its own matcher methods, but it's a bit late now.

from javahamcrest.

EarthCitizen avatar EarthCitizen commented on July 2, 2024

What will break if the signature of equalTo() is changed now? Would it affect a small number of users or create a large inconvenience for most?

from javahamcrest.

sf105 avatar sf105 commented on July 2, 2024

People using asserThat directly will be fine, apart from occasionally missing a helpful type clash when refactoring. People using Hamcrest with JMock (and maybe other mock frameworks) will get compilation failures.

from javahamcrest.

EarthCitizen avatar EarthCitizen commented on July 2, 2024

What do you think a good solution would be?

from javahamcrest.

npryce avatar npryce commented on July 2, 2024

The only solution is to add another matcher factory method. E.g.

isEqualToObject(Object o) -> Matcher

from javahamcrest.

npryce avatar npryce commented on July 2, 2024

Implemented in master.

from javahamcrest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.