Comments (7)
I'm currently hitting warnings with IsIterableContainingInOrder.contains
Should @SafeVarArgs
be added to this and other methods also? I.e. should this fix be extended to annotate methods which might not have had overloads to begin with?
(Or might it be that these methods are not actually safe to annotate this way...?)
from javahamcrest.
Even with 2.0.0.0 I still do not see the annotation on org.hamcrest.Matchers.contains(...)
therefore I still get the following warning
Type safety: A generic array of Matcher<? super something> is created for a varargs parameter
from javahamcrest.
I think this was closed preliminarily (unless it was meant as a "won't fix", but then a comment would be nice).
I propose all of the varargs methods in Matchers
should get this annotation, as well as the static methods they are delegating to. (Unless there are some which actually write into the array, but I don't think that is happening here.)
(I don't understand how this changes the ABI ... the method still accepts an array of the upper bound type, right?)
from javahamcrest.
@sf105 Would you consider reopening this?
from javahamcrest.
Agreed. This have got too confused.
from javahamcrest.
What exactly will be done with this issue? It looks like the current source has the @SafeVarargs
annotation:
https://github.com/hamcrest/JavaHamcrest/blob/master/hamcrest/src/main/java/org/hamcrest/Matchers.java#L886
Will there ever be another release with this change? (Release is out, but under different artifactId)
Isn't this issue technically resolved (but not by the original milestone)?
from javahamcrest.
Agree, closing this.
from javahamcrest.
Related Issues (20)
- containsInAnyOrder incorrectly identifies differences in identical collections HOT 1
- Hamcrest 3.0? HOT 2
- You should be able to specify a lambda to return a reason
- Conflicting license declarations HOT 1
- Not sure why assertThat() doesn't work in this case HOT 2
- 301 Moved Permanently
- assertThat(this.object, hasProperty("booleanName")) fails to match boolean types and renames the property HOT 1
- The matcher contains() is misleading HOT 2
- FR: Matching maps with various type HOT 1
- oss-fuzz integration
- Participitation in Hacktoberfest?
- HasProperty Matcher doesn't work with Java Records HOT 1
- assertThat(Int::class.java, typeCompatibleWith(Number::class.java)) in kotlin always fails
- hamcrest matching on actual empty list fails with nosuchmethoderror HOT 1
- Test output Alignment
- record version fails the hasProperty HOT 1
- has property fails with non public class.. not sure if this correct as per java standards of property
- Double "close-to" matcher that uses the ULP.
- GraalVM Native Image support HOT 3
- Inquiry about Project Activity and Future Plans HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from javahamcrest.