hamiltonparker / learning

Testing repository

learning

First python project

Full API Documentation available at: github pages.

learning's Issues

Possible change of integer check

You may want to consider changing the way you check for integers from (a).is_integer() to (a%1==0):

import time
start = time.clock()
for i in range(10000):
    a = np.random.rand()
    (a).is_integer()
print((time.clock() - start)/10000)
1.4211e-06

start = time.clock()
for i in range(10000):
    a = np.random.rand()
    a%1==0
print((time.clock() - start)/10000)
1.2945e-06

it's not a huge time savings but when your making the call a few thousand times it adds up.

Identify lattice vectors in documentation.

It would be nice to know which basis goes to which subroutine you're writing. That way if I want to check the efficiency/logic of a subroutine I can look at the relationships for the basis in question directly.