Comments (5)
@danelowe Hello, I'm sorry about this poor experience. I've just merged a PR that fixes this problem
In your case, it will return:
form = Admin::Forms::Job::Search.new(filter: {customer_name: 'Buster'})
form.to_h # => { :filter => { :customer_name => "Buster" }}
Please let me know if it still doesn't work for you. Thanks.
from validations.
Hey @jodosha Thanks so much for looking into this. It seems to work, but it also seems another regression may have been introduced?
require 'lotus/validations'
class Form
include Lotus::Validations
attribute :tags, type: Array
end
form = Form.new(tags: [:te, :st])
form.to_h
lib/lotus/utils/hash.rb:31:in 'to_h': wrong element type Symbol at 0 (expected array) (TypeError)
I guess it comes from Lotus::Utils::Attributes#_read_attribute.
If the value is an array, it responds to to_h, but will raise an error unless the array happens to be in the right 'format' for converting to a hash.
from validations.
@danelowe Sorry, you're right. 😿 That's because latest versions of Ruby have introduced Array#to_h
. Fix is on the way.
from validations.
@danelowe Can you please try again with master? Thank you and sorry again for the troubles.
from validations.
@jodosha My tests are now passing 🎉 thanks!
from validations.
Related Issues (20)
- [Question] Validation Object receiving key arguments as string or symbol HOT 4
- Make validations a callable object HOT 2
- Fail on incomplete expression? HOT 1
- Error if each macro is used with a single check HOT 2
- Router params treated differently in RSpec HOT 4
- Wrap rule errors by namespace HOT 4
- +key?+ is not a valid predicate name HOT 1
- Unable to use I18n w/o manually requiring dry/validations/messages/i18n
- i18n and predicate are not working well HOT 2
- dry-validation val() doesn't work for predicates HOT 1
- Support for preprocessing? HOT 1
- Add a simple a helper method to shorten validate.success? with valid? [Law of Demeter] HOT 1
- Nested Validations Not Working HOT 2
- validate blocks raise an exception about missing messages HOT 3
- Upgrade to dry-validation v1.0 or remove dependency from Hanami HOT 7
- v2.0.0.alpha1, 2.0 suggestion. HOT 3
- Updating dry-validation ? HOT 3
- hanami-validations is not ruby 3 compatible HOT 3
- Unexpected value returned from `Hanami::Validations::Namespace` HOT 3
- Missing CSRF token makes params invalid in test HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from validations.