param not required is still validated about validations

[caspg]

Since we can get an empty string (but we don't want to check if this param is present), we could use for example #blank_value? method and change:
https://github.com/lotus/validations/blob/master/lib/lotus/validations/attribute.rb#L213-L215

def skip?
  @value.nil?
end

to:

def skip?
  blank_value?
end

@jodosha What do you think?

[runlevel5]

@caspg thanks for the bug report, can you verify if this also the case for using lotus/validation alone with other framework?

[caspg]

@joneslee85 I'm not sure how can I use lotus/validation for params in other frameworks. But sinatra and rails, also return empty string ("") as a param, when you submit empty input. So I believe that problem will be the same. That's why I think we should check in skip? method if value is nil or empty string.

[jodosha]

@caspg Thanks for reporting this issue 👍

That strategy that involves "blank" fixes your problem, but creates a new one.

class SizeValidator
  include Lotus::Attributes
  attribute :tags, size: 3
end

SizeValidator.new.valid? # => true - OK
SizeValidator.new(tags: []).valid? # => true - OUCH

But you give us a great hint ✨

Please check if the attached PR fixes your case.

[caspg]

@jodosha With PR it works great, thanks 😃

[jodosha]

@caspg 🎩