bad duration in .ts files about handbrake

[sr55]

Just to confirm, are the Subtitles OK to the 24 minute mark then stop?

It's not unsurprising the file duration is mis-reported due to the lack of a file header. HandBrake still read to the end of the file and found over 25 minutes worth of content. That shouldn't have stopped the subtitles also completing though.

Are you able to share a sample file that reproduces this?

[FiveVampires]

Yes. Encoded video is ok and has 25:15. But subtitles stop after 24:09. Sample... in hardsub - subtitles just stop showing. In softsub - all lines after 24:09 are erased. Just made one fast encode. Im not able to extract subtitles from that mkv so just attached it as MKS. Also attached original testing subtitles and activity log. subtitles are in ZIP.

subs.zip

Video-1_encode_01.24.2024 13-38-31.txt

[galad87]

The SSA and SRT demuxers stop demuxing when they reach the approximated file duration, so that's why you aren't seeing any subtitles after that.
I think it should be possible to remove this limitation without any side effect.

[jstebbins]

hmm, you might want to check what happens on the muxer side of things. I think what can happen if you remove the demuxer limit is the creation of an output file whose duration matches the duration of the external SRT file even when the source video is much shorter.

We might need to monitor timestamps in the muxer and only output subtitles that have a video frame that follows. This would need to be done in muxcommon.c.

[galad87]

Oh right, I did test only burned-in and tx3g, which requires additional conversions and so it already dropped the unneeded subtitles lines. But going from SSA to SSA does keep all the subtitles lines after the video ends.

[FiveVampires]

it would also help if the user could manually set it...

[galad87]

It should be already possible to manually set the duration in the UI, and HandBrake will try to encode up to the duration set.

[FiveVampires]

It should be already possible to manually set the duration in the UI, and HandBrake will try to encode up to the duration set.

you are right - there is something like that, but it is not working for this subtitles problem - I tried it several times...