Last few captions from SRT input file do not appear in MP4 output about handbrake

[vobine]

Here's my patch that makes it work for me. I do not think this is a fix, but we live in hope.

commit 3a6bd9b8549b29d1d2c96f6f48bd3b2aca8b0d63 (HEAD -> hrp-subtitles-20240122)
Author: Hal Peterson <[email protected]>
Date:   Tue Jan 23 16:28:51 2024 -0600

    Remove checks for subtitle timestamp mismatch with chapter, because on at least two examples, it spuriously discards the last few subtitles.  THIS IS NOT A FIX.

diff --git a/libhb/decsrtsub.c b/libhb/decsrtsub.c
index 17b714b0a..eb9768e4b 100644
--- a/libhb/decsrtsub.c
+++ b/libhb/decsrtsub.c
@@ -367,11 +367,14 @@ static hb_buffer_t *srt_read( hb_work_private_t *pv )
                     start_time >= pv->stop_time)
                 {
                     hb_deep_log( 3, "Discarding SRT at time start %"PRId64", stop %"PRId64, start_time, stop_time);
+#ifdef HRP_HACK_20240119_0735
                     memset( &pv->current_entry, 0, sizeof( srt_entry_t ) );
                     ++(pv->number_of_entries);
                     pv->current_state = k_state_timecode;
                     continue;
+#endif // HRP_HACK_20240119_0735
                 }
+#ifdef HRP_HACK_20240119_0752
                 if (start_time < pv->start_time)
                 {
                     start_time = pv->start_time;
@@ -380,7 +383,7 @@ static hb_buffer_t *srt_read( hb_work_private_t *pv )
                 {
                     stop_time = pv->stop_time;
                 }
-
+#endif // HRP_HACK_20240119_0752
                 for (q = p = pv->current_entry.text; *p != '\0'; p++)
                 {
                     if (*p == '\r' || *p == '\n')
@@ -439,8 +442,10 @@ static hb_buffer_t *srt_read( hb_work_private_t *pv )
         if( !( start_time >= pv->start_time && stop_time < pv->stop_time ) )
         {
             hb_deep_log( 3, "Discarding SRT at time start %"PRId64", stop %"PRId64, start_time, stop_time);
+#ifdef HRP_HACK_20240122_0848
             memset( &pv->current_entry, 0, sizeof( srt_entry_t ) );
             return hb_buffer_eof_init();
+#endif // HRP_HACK_20240122_0848
         }
 
         for (q = p = pv->current_entry.text; *p != '\0'; p++)

[galad87]

It's the same issue described in #5714, from the activity log you can see that HandBrake thinks the duration is 00:28:51.
However, if you open the VIDEO_TS folder instead of the single .vob file you will get the correct duration, plus additional info like tracks languages. Opening a .vob file is usually the resort, it should be avoid if you have a valid DVD-Video structure (a VIDEO_TS folder with all the .ifo files).