DatumPath.numbersLessThan Bug? 🪲 about hapi-hl7v2

[milkshakeuk]

@ohr, @jamesagnew

I've done some more comparisons this time using IKVM to load the hapi-base-2.3.jar into my dotnet unit test project so I could compare the output and here are the results.

Looks like I haven't made a mistake in the porting process as they both return the same results give then example above.

[milkshakeuk]

@jamesagnew @ohr

I believe this will fix it, I have made the change in the nhapi port and it seems to fix it (proven with unit tests), assuming that's the expected behaviour and I am not misunderstanding it.

public boolean numbersLessThan(DatumPath other)
{
	DatumPath extendedCopyThis = new DatumPath(this);
	extendedCopyThis.setSize(s_maxSize);

	DatumPath extendedCopyOther = new DatumPath(other);
	extendedCopyOther.setSize(s_maxSize);

	boolean lessThan = false;
	for(int i=1; !lessThan && (i<s_maxSize); ++i) {
		int this_i = ((Integer)extendedCopyThis.get(i));
		int other_i = ((Integer)extendedCopyOther.get(i));
		// this following line is the fix
		// if this_i is greater than other_i then just stop iterating as the answer is clearly false.
		if(this_i > other_i) break;
		lessThan = (this_i < other_i);
	}

	return lessThan;
}

I would create a PR however I have yet been successful in actually building hapi never mind running the test suite.

[milkshakeuk]

@jamesagnew did you see this?